Public bug reported: There are a lot of places where LibvirtConfigObject.to_xml() is called and then the results are logged in context, like in the libvirt driver code:
http://logs.openstack.org/55/218355/5/check/gate-tempest-dsvm-neutron- full/4dce003/logs/screen-n-cpu.txt.gz#_2015-09-01_19_07_16_539 It would actually be nicer to log those in the context of the instance uuid we're working on, so we get the instance highlighting in the logs for debugging. So I think we should remove the LOG.debug call here: http://git.openstack.org/cgit/openstack/nova/tree/nova/virt/libvirt/config.py#n82 And for any time that we do really want that xml logged, we can do it in the calling code where we will usually also have the instance uuid in context and can log that also. ** Affects: nova Importance: Low Assignee: Matt Riedemann (mriedem) Status: Triaged ** Tags: libvirt serviceability ** Changed in: nova Importance: Undecided => Low ** Changed in: nova Status: New => Triaged ** Changed in: nova Assignee: (unassigned) => Matt Riedemann (mriedem) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1491414 Title: LibvirtConfigObject.to_xml() should not log the xml str - leave that to the caller Status in OpenStack Compute (nova): Triaged Bug description: There are a lot of places where LibvirtConfigObject.to_xml() is called and then the results are logged in context, like in the libvirt driver code: http://logs.openstack.org/55/218355/5/check/gate-tempest-dsvm-neutron- full/4dce003/logs/screen-n-cpu.txt.gz#_2015-09-01_19_07_16_539 It would actually be nicer to log those in the context of the instance uuid we're working on, so we get the instance highlighting in the logs for debugging. So I think we should remove the LOG.debug call here: http://git.openstack.org/cgit/openstack/nova/tree/nova/virt/libvirt/config.py#n82 And for any time that we do really want that xml logged, we can do it in the calling code where we will usually also have the instance uuid in context and can log that also. To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1491414/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
