AFAIK the flavor extra specs are free form string values and there is
no defined list of allowed values. That's why it's not possible to
check if the provided input is sane. The code 201 the REST API returns
just says that your request (create/update an extra spec) got fulfilled.
It doesn't say that it is sane. That's why I think it's fair to close 
this bug.

** Changed in: nova
       Status: New => Invalid

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1515720

Title:
  flavor extra specs: Input parameters need error check

Status in OpenStack Compute (nova):
  Invalid

Bug description:
  By mistake I gave parameter with wrong extra spec
  "quota:quota:vif_shares_share=10" instead of
  "quota:vif_shares_share=10", executing of command was successful. I
  didnt see same Shares value being set on VM NIC as expected.

  It might be good idea to validate the parameters before returning
  success.

  Build Version: VIO 2.0 GA + NSX 6.2 GA

  root@blr-vio-dhcp:~# nova flavor-key m1.spirent set 
quota:quota:vif_shares_share=10
  root@blr-vio-dhcp:~# nova flavor-show m1.spirent
  
+----------------------------+----------------------------------------------------------------------------------------------------------------------------------+
  | Property                   | Value                                          
                                                                                
  |
  
+----------------------------+----------------------------------------------------------------------------------------------------------------------------------+
  | OS-FLV-DISABLED:disabled   | False                                          
                                                                                
  |
  | OS-FLV-EXT-DATA:ephemeral  | 0                                              
                                                                                
  |
  | disk                       | 5                                              
                                                                                
  |
  | extra_specs                | {"quota:vif_shares_level": "custom", 
"quota:quota:vif_shares_share": "10", "quota:vif_limit": "5", 
"quota:vif_reservation": "3"} |
  | id                         | 6                                              
                                                                                
  |
  | name                       | m1.spirent                                     
                                                                                
  |
  | os-flavor-access:is_public | True                                           
                                                                                
  |
  | ram                        | 2048                                           
                                                                                
  |
  | rxtx_factor                | 1.0                                            
                                                                                
  |
  | swap                       |                                                
                                                                                
  |
  | vcpus                      | 2                                              
                                                                                
  |
  
+----------------------------+----------------------------------------------------------------------------------------------------------------------------------+
  root@blr-vio-dhcp:~#

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1515720/+subscriptions

-- 
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help   : https://help.launchpad.net/ListHelp

Reply via email to