Reviewed: https://review.openstack.org/242588 Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=4dad7c5004dbddb52f732c7a3cd15be6be155904 Submitter: Jenkins Branch: master
commit 4dad7c5004dbddb52f732c7a3cd15be6be155904 Author: Timur Sufiev <[email protected]> Date: Fri Nov 6 21:14:04 2015 +0300 Fix 3-components accessors for TabbedTables in i9n tests When using just 2 last segments of the path to table for generating accessor method name it's possible that resulting names will clash, say for Project->Compute->Volumes->Volumes and for Admin->System->Volumes->Volumes. To avoid this situation, we need to use 3 components name for tables which are at 4th level of nesting. Change-Id: If63ae14a99f4c53030927f96a69b7189bd83c4e5 Closes-Bug: #1467615 ** Changed in: horizon Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1467615 Title: Integration test navigation overwrites itself. Status in OpenStack Dashboard (Horizon): Fix Released Bug description: The integration tests use a navigation menu structure to create go_to_ functions for each page path. https://github.com/openstack/horizon/blob/master/openstack_dashboard/test/integration_tests/pages/navigation.py#L49 https://github.com/openstack/horizon/blob/master/openstack_dashboard/test/integration_tests/pages/navigation.py#L257 Unfortunately it only uses the last two segments of the path to generate the name resulting in an overwrite of previously defined functions. https://github.com/openstack/horizon/blob/master/openstack_dashboard/test/integration_tests/pages/navigation.py#L279 Ex: [Project/Compute/Volumes/Volumes] creates: go_to_volumes_volumespage https://github.com/openstack/horizon/blob/master/openstack_dashboard/test/integration_tests/pages/navigation.py#L69 Which is the same as.... [Admin/System/Volumes/Volumes] creates: go_to_volumes_volumespage https://github.com/openstack/horizon/blob/master/openstack_dashboard/test/integration_tests/pages/navigation.py#L146 This causes issues when trying to generate tests for volumes or any other conflicting pair. Thanks. To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1467615/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
