Reviewed: https://review.openstack.org/260431 Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=b147f60f9aec971fdee568c530183ced7255d619 Submitter: Jenkins Branch: master
commit b147f60f9aec971fdee568c530183ced7255d619 Author: Akihiro Motoki <[email protected]> Date: Tue Dec 22 19:14:37 2015 +0900 Restore _validate_subnet/uuid_list not to break subproject gates https://review.openstack.org/#/c/258867/ removed _validate_subnet_list and _validate_uuid_list. _validate_subnet_list is being used in VPNaaS and VPNaaS gate is now broken. We need to remove validators more carefully because subprojects may use them. This commit restores them once. Change-Id: I9c40b9d67a8364f698cc9bf604e4e1f4caea413e Closes-Bug: #1528435 ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1528435 Title: The gate test of VPNaaS is failing with AttributeError Status in neutron: Fix Released Bug description: When I run git review command on today(AM 10:00), the gate test of VPNaaS is failing with following error. There are 5 errors and all of errors are AttributeError. I guess that following recent modification affects https://github.com/openstack/neutron/commit/dd5f5716c9a32634caa2a44d362cd77461ba873d *Error details Traceback (most recent call last): File "/home/ubuntu/for_commit/midonet/.tox/py27/local/lib/python2.7/site-packages/oslo_db/api.py", line 137, in wrapper return f(*args, **kwargs) File "/home/ubuntu/for_commit/midonet/.tox/py27/src/neutron/neutron/api/v2/base.py", line 414, in create allow_bulk=self._allow_bulk) File "/home/ubuntu/for_commit/midonet/.tox/py27/src/neutron/neutron/api/v2/base.py", line 680, in prepare_request_body attributes.convert_value(attr_info, res_dict, webob.exc.HTTPBadRequest) File "/home/ubuntu/for_commit/midonet/.tox/py27/src/neutron/neutron/api/v2/attributes.py", line 919, in convert_value res = validators[rule](res_dict[attr], attr_vals['validate'][rule]) File "/home/ubuntu/for_commit/midonet/.tox/py27/src/neutron-vpnaas/neutron_vpnaas/extensions/vpnaas.py", line 167, in _validate_subnet_list_or_none attr._validate_subnet_list(data, key_specs) AttributeError: 'module' object has no attribute '_validate_subnet_list' 2015-12-22 02:24:21,828 ERROR [neutron.api.v2.resource] create failed Traceback (most recent call last): File "/home/ubuntu/for_commit/midonet/.tox/py27/src/neutron/neutron/api/v2/resource.py", line 83, in resource result = method(request=request, **args) File "/home/ubuntu/for_commit/midonet/.tox/py27/local/lib/python2.7/site-packages/oslo_db/api.py", line 152, in wrapper ectxt.value = e.inner_exc File "/home/ubuntu/for_commit/midonet/.tox/py27/local/lib/python2.7/site-packages/oslo_utils/excutils.py", line 204, in __exit__ six.reraise(self.type_, self.value, self.tb) File "/home/ubuntu/for_commit/midonet/.tox/py27/local/lib/python2.7/site-packages/oslo_db/api.py", line 137, in wrapper return f(*args, **kwargs) File "/home/ubuntu/for_commit/midonet/.tox/py27/src/neutron/neutron/api/v2/base.py", line 414, in create allow_bulk=self._allow_bulk) File "/home/ubuntu/for_commit/midonet/.tox/py27/src/neutron/neutron/api/v2/base.py", line 680, in prepare_request_body attributes.convert_value(attr_info, res_dict, webob.exc.HTTPBadRequest) File "/home/ubuntu/for_commit/midonet/.tox/py27/src/neutron/neutron/api/v2/attributes.py", line 919, in convert_value res = validators[rule](res_dict[attr], attr_vals['validate'][rule]) File "/home/ubuntu/for_commit/midonet/.tox/py27/src/neutron-vpnaas/neutron_vpnaas/extensions/vpnaas.py", line 167, in _validate_subnet_list_or_none attr._validate_subnet_list(data, key_specs) AttributeError: 'module' object has no attribute '_validate_subnet_list' To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1528435/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
