Reviewed: https://review.openstack.org/262692 Committed: https://git.openstack.org/cgit/openstack/congress/commit/?id=89b6fa066585e1d80a1b5203594f4b696446f62b Submitter: Jenkins Branch: master
commit 89b6fa066585e1d80a1b5203594f4b696446f62b Author: Shuquan Huang <[email protected]> Date: Thu Dec 31 15:49:57 2015 +0800 Change assertTrue(isinstance()) by optimal assert Some of tests use different method of assertTrue(isinstance(A, B)) or assertEqual(type(A), B). The correct way is to use assertIsInstance(A, B) provided by testtools. Change-Id: I17efd64bf4031788f03cf46468b77d7072981620 Closes-bug: #1268480 ** Changed in: congress Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1268480 Title: assertTrue(isinstance()) in tests should be replace with assertIsInstance() Status in Barbican: In Progress Status in Ceilometer: Fix Released Status in Cinder: In Progress Status in CloudRoast: New Status in congress: Fix Released Status in Glance: Fix Released Status in heat: Fix Released Status in OpenStack Dashboard (Horizon): Fix Released Status in Ironic: Fix Released Status in ironic-python-agent: In Progress Status in OpenStack Identity (keystone): Fix Released Status in Manila: In Progress Status in neutron: Invalid Status in OpenStack Compute (nova): Fix Released Status in python-ceilometerclient: Fix Released Status in python-cinderclient: Fix Released Status in python-glanceclient: Fix Released Status in python-keystoneclient: Fix Released Status in python-novaclient: Fix Released Status in OpenStack SDK: In Progress Status in tempest: In Progress Bug description: some of tests use different method of assertTrue(isinstance(A, B)) or assertEqual(type(A), B). The correct way is to use assertIsInstance(A, B) provided by testtools To manage notifications about this bug go to: https://bugs.launchpad.net/barbican/+bug/1268480/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
