Reviewed: https://review.openstack.org/270871 Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=06a3b0da2422645129b91a8ca7d5bbdc867fc5d1 Submitter: Jenkins Branch: master
commit 06a3b0da2422645129b91a8ca7d5bbdc867fc5d1 Author: Matt Borland <[email protected]> Date: Thu Jan 21 08:38:50 2016 -0700 Only specify use of html5 locationProvider if base tag This fixes a bug introduced by the use of the locationProvider to assume a base tag is present. For Launch Instance (Angular) it may be present on a page that doesn't use Angular routing (this is OK as the modals don't currently use such routing). To test the fix, you should make sure that you can open and see the Launch Instance Wizard (Angular) without any JavaScript errors. On the flip side, you should enable an Angular panel (e.g. Images) and ensure that it loads without error. To fully test routing, you'll need to pull the patch: https://review.openstack.org/#/c/173885/ Change-Id: I021d8fdb2e96eefad03182d251445d0b8ab2fa28 Closes-Bug: 1536681 ** Changed in: horizon Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1536681 Title: launch instance cannot use location provider Status in OpenStack Dashboard (Horizon): Fix Released Bug description: A recently merged patch introduced the use of html5 mode for Angular's locationProvider. However, this implementation doesn't check whether the page has a base tag, and blindly tries to enable html5 mode. For pages where there is no base tag, this will produce a JavaScript error. This breaks the Angular Launch Instance feature when launched from a page that doesn't specify the base tag (most pages that provide the Launch Instance feature). To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1536681/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
