Reviewed: https://review.openstack.org/276519 Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=96c67e22f9cba2ea0e7fb3ba2a63e4905e48c1a4 Submitter: Jenkins Branch: master
commit 96c67e22f9cba2ea0e7fb3ba2a63e4905e48c1a4 Author: Kevin Benton <[email protected]> Date: Thu Feb 4 13:49:42 2016 -0800 Only ensure admin state on ports that exist The linux bridge agent was calling ensure_port_admin state unconditionally on ports in treat_devices_added_or_updated. This would cause it to throw an error on interfaces that didn't exist so it would restart the entire processing loop. If another port was being updated in the same loop before this one, that port would experience a port status life-cycle of DOWN->BUILD->ACTIVE->BUILD->ACTIVE ^ <--- Exception in unrelated port causes cycle to start over again. This causes the bug below because the first active transition will cause Nova to boot the VM. At this point tempest tests expect the ports that belong to the VM to be in the ACTIVE state so it filters Neutron port list calls with "status=ACTIVE". Therefore tempest would not get any ports back and assume there was some kind of error with the port and bail. This patch just makes sure the admin state call is skipped if the port doesn't exist and it includes a basic unit test to prevent a regression. Closes-Bug: #1523638 Change-Id: I5330c6111cbb20bf45aec9ade7e30d34e8dd16ca ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1523638 Title: tempest fails with No IPv4 addresses found Status in neutron: Fix Released Status in tempest: In Progress Bug description: http://logs.openstack.org/42/250542/7/check/gate-tempest-dsvm-neutron- linuxbridge/3a00f8b/logs/testr_results.html.gz Traceback (most recent call last): File "tempest/test.py", line 113, in wrapper return f(self, *func_args, **func_kwargs) File "tempest/scenario/test_network_basic_ops.py", line 550, in test_subnet_details self._setup_network_and_servers(dns_nameservers=[initial_dns_server]) File "tempest/scenario/test_network_basic_ops.py", line 123, in _setup_network_and_servers floating_ip = self.create_floating_ip(server) File "tempest/scenario/manager.py", line 842, in create_floating_ip port_id, ip4 = self._get_server_port_id_and_ip4(thing) File "tempest/scenario/manager.py", line 821, in _get_server_port_id_and_ip4 "No IPv4 addresses found in: %s" % ports) File "/opt/stack/new/tempest/.tox/full/local/lib/python2.7/site-packages/unittest2/case.py", line 845, in assertNotEqual raise self.failureException(msg) AssertionError: 0 == 0 : No IPv4 addresses found in: [] To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1523638/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
