Reviewed: https://review.openstack.org/275747 Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=e19bb206bb0332c6a772d44654fa474642ddc429 Submitter: Jenkins Branch: master
commit e19bb206bb0332c6a772d44654fa474642ddc429 Author: Justin Pomeroy <[email protected]> Date: Wed Feb 3 09:06:45 2016 -0600 Use OS::Nova::Server resource type for instance metadata Horizon currently uses the OS::Nova::Instance resource type when querying for instance metadata, but it should use OS::Nova::Server to align with Heat and Searchlight. See also: https://review.openstack.org/272271 Closes-Bug: #1537903 Change-Id: I1deab8ed74515d08301e68bd2c75604d35592c50 ** Changed in: horizon Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to Glance. https://bugs.launchpad.net/bugs/1537903 Title: Glance metadefs for OS::Nova::Instance should be OS::Nova::Server Status in Glance: Fix Released Status in OpenStack Dashboard (Horizon): Fix Released Bug description: The metadata definitions in etc/metadefs allow each namespace to be associated with a resource type in OpenStack. Now that Horizon is supporting adding metadata to instances (just got in during the mitaka cycle - so unrealeased), I realized that we used OS::Nova::Instance instead of OS::Nova::Server in Glance. This doesn’t align with Heat [0] or Searchlight [1]. Glance Issue: There are a couple of metadef files that have OS::Nova::Instance that need to change to OS::Nova::Server. I see also that OS::Nova:Instance is in one of the db scripts. That script simply adds some initial "resource types" to the database. [3]. It should be noted that there is no hard dependency on that resource type in the DB script. You can add new resource types at any time via API or JSON files and they are automatically added. I'm not sure if the change to the db script needs to be done in a different patch or not, but that can easily be accommodated. Horizon Issue: The instance update metadata action and NG launch instance should retrieve OS::Nova::Server instead. The Horizon patch shouldn't merge until the glance patch merges, but there is not an actual hard dependency between the two. [0] http://docs.openstack.org/developer/heat/template_guide/openstack.html#OS::Nova::Server [1] https://github.com/openstack/searchlight/blob/master/searchlight/elasticsearch/plugins/nova/servers.py#L35 [3] https://github.com/openstack/glance/search?utf8=%E2%9C%93&q=%22OS%3A%3ANova%3A%3AInstance%22 Finally: It should be noted that updating namespaces in Glance is already possible with glance-manage. E.g. ttripp@ubuntu:/opt/stack/glance$ glance-manage db_load_metadefs etc/metadefs -h usage: glance-manage db_load_metadefs [-h] [path] [merge] [prefer_new] [overwrite] positional arguments: path merge prefer_new overwrite So, you just have to call: ttripp@ubuntu:/opt/stack/glance$ glance-manage db_load_metadefs etc/metadefs true true See also: https://youtu.be/zJpHXdBOoeM To manage notifications about this bug go to: https://bugs.launchpad.net/glance/+bug/1537903/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
