Reviewed: https://review.openstack.org/264245 Committed: https://git.openstack.org/cgit/openstack/python-manilaclient/commit/?id=1a9d0b713dd6e4a990d60ab81de9e57cf1845292 Submitter: Jenkins Branch: master
commit 1a9d0b713dd6e4a990d60ab81de9e57cf1845292 Author: LiuNanke <[email protected]> Date: Thu Jan 7 00:03:25 2016 +0800 Replace assertTrue(isinstance()) with assertIsInstance() Some of tests use different method of assertTrue(isinstance(A, B)) or assertEqual(type(A), B). The correct way is to use assertIsInstance(A, B) provided by testtools. There has one more place should be modified. Closes-bug: #1268480 Change-Id: I05d1b75289e193a32bd4d0ba0557af3fad686880 ** Changed in: python-manilaclient Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to anvil. https://bugs.launchpad.net/bugs/1268480 Title: assertTrue(isinstance()) in tests should be replace with assertIsInstance() Status in anvil: In Progress Status in Barbican: Fix Released Status in Ceilometer: Fix Released Status in Cinder: In Progress Status in CloudRoast: In Progress Status in congress: Fix Released Status in Glance: Fix Released Status in heat: Fix Released Status in OpenStack Dashboard (Horizon): Fix Released Status in ironic-python-agent: Fix Released Status in OpenStack Identity (keystone): Fix Released Status in Magnum: In Progress Status in Manila: Fix Released Status in Mistral: Fix Released Status in Monasca: Fix Released Status in Murano: Fix Released Status in networking-powervm: In Progress Status in neutron: Fix Released Status in OpenStack Compute (nova): Fix Released Status in python-ceilometerclient: Fix Released Status in python-cinderclient: Fix Released Status in python-glanceclient: Fix Released Status in python-heatclient: In Progress Status in python-keystoneclient: Fix Released Status in python-manilaclient: Fix Released Status in python-novaclient: Fix Released Status in python-openstackclient: In Progress Status in OpenStack SDK: Fix Released Status in python-rackclient: In Progress Status in Rally: In Progress Status in Sahara: Fix Released Status in OpenStack Object Storage (swift): In Progress Status in tempest: In Progress Status in Trove: Fix Released Bug description: some of tests use different method of assertTrue(isinstance(A, B)) or assertEqual(type(A), B). The correct way is to use assertIsInstance(A, B) provided by testtools To manage notifications about this bug go to: https://bugs.launchpad.net/anvil/+bug/1268480/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
