Reviewed: https://review.openstack.org/284234 Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=847a35a6491504aa0f920c7027032977c86ee622 Submitter: Jenkins Branch: master
commit 847a35a6491504aa0f920c7027032977c86ee622 Author: Brian Haley <[email protected]> Date: Wed Feb 24 10:22:18 2016 -0600 Fix test_get_device_id() failure on OSX A recent change to fix a mock issue in bug 1544522 broke this test on OSX because it's using the FQDN as cfg.HOST.host. Change-Id: Ib6098abb16511c91865382834e25d2b96d3eab94 Closes-bug: #1549364 ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1549364 Title: DHCP agent test fails on OSX Status in neutron: Fix Released Bug description: A recent change to fix a mock issue, https://bugs.launchpad.net/neutron/+bug/1544522 broke one of the DHCP agent tests on OSX. neutron.tests.unit.agent.dhcp.test_agent.TestDeviceManager.test_get_device_id ----------------------------------------------------------------------------- Captured traceback: ~~~~~~~~~~~~~~~~~~~ Traceback (most recent call last): File "neutron/tests/unit/agent/dhcp/test_agent.py", line 1521, in test_get_device_id uuid5.assert_called_once_with(uuid.NAMESPACE_DNS, cfg.CONF.host) File "/Users/haley/neutron/.tox/py27/lib/python2.7/site-packages/mock/mock.py", line 948, in assert_called_once_with return self.assert_called_with(*args, **kwargs) File "/Users/haley/neutron/.tox/py27/lib/python2.7/site-packages/mock/mock.py", line 937, in assert_called_with six.raise_from(AssertionError(_error_message(cause)), cause) File "/Users/haley/neutron/.tox/py27/lib/python2.7/site-packages/six.py", line 718, in raise_from raise value AssertionError: Expected call: uuid5(UUID('6ba7b810-9dad-11d1-80b4-00c04fd430c8'), 'Spaceship-Three.local') Actual call: uuid5(UUID('6ba7b810-9dad-11d1-80b4-00c04fd430c8'), 'Spaceship-Three') The test needs to change to not use the FQDN. To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1549364/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
