Reviewed: https://review.openstack.org/287520 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=ac5e95e39707a773100fa31f5057c2ace881e4e4 Submitter: Jenkins Branch: master
commit ac5e95e39707a773100fa31f5057c2ace881e4e4 Author: Jim Rollenhagen <[email protected]> Date: Wed Mar 2 16:02:08 2016 -0800 Ironic: Clean up if configdrive build fails The configdrive builder does a number of things; for instance, shelling out to mkisofs or reaching up to the top cell for SSH keys. These have ways of failing. If they do fail, we need to cleanup what we've done in the deploy so far (instance fields on the node in ironic, firewalls, vifs, etc). Wrap the configdrive build call in a try/except to catch any errors, clean up, and re-raise the error. Change-Id: I81ec4c54437d92c4c091646c0b3f5d948b82b52b Closes-Bug: #1552466 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1552466 Title: Ironic: deploy not cleaned up if configdrive fails to build Status in OpenStack Compute (nova): Fix Released Bug description: The _generate_configdrive is not protected by a try/except, and thus we do not clean up behind it if it fails somehow. This leaves firewalls and vifs set up, and leaves instance info on the node in ironic's DB. To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1552466/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
