Reviewed: https://review.openstack.org/285922 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=7c2cab6208a5fb51f2e735fcce43b6028fa5a33d Submitter: Jenkins Branch: master
commit 7c2cab6208a5fb51f2e735fcce43b6028fa5a33d Author: Eli Qiao <[email protected]> Date: Mon Feb 29 15:23:33 2016 +0800 API: Mapping ConsoleTypeInvalid exception to HTTPBadRequest We need to catch up ConsoleTypeInvalid in API layer to avoid 500 error in case we passed invalid console type (> v2.6). Closes-Bug: #1551104 Change-Id: I8be6dd1efd9057fb582713e0fe9fe0d626832fda ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1551104 Title: get-XXX-console returns 500 while an expected exception ConsoleTypeInvalid raised Status in OpenStack Compute (nova): Fix Released Bug description: 1. Exact version of Nova/OpenStack you are running: Master 791e5421cdc2130ed80e067e43b6006a6859138b 2. Relevant log files: taget@taget-ThinkStation-P300:~/devstack$ nova get-vnc-console testvm ee ERROR (BadRequest): Invalid input for field/attribute type. Value: ee. u'ee' is not one of ['novnc', 'xvpvnc', 'rdp-html5', 'spice-html5', 'serial', 'webmks'] (HTTP 400) (Request-ID: req-8bd1cada-caf4-4c9f-afa3-1afe7655472d) taget@taget-ThinkStation-P300:~/devstack$ nova get-vnc-console testvm xvpvnc +--------+------------------------------------------------------------------------------+ | Type | Url | +--------+------------------------------------------------------------------------------+ | xvpvnc | http://10.238.157.49:6081/console?token=a7275c37-7397-414a-ba3f-1da4a03d2115 | +--------+------------------------------------------------------------------------------+ taget@taget-ThinkStation-P300:~/devstack$ nova get-vnc-console testvm rdp-html5 ERROR (ClientException): Unexpected API Error. Please report this at http://bugs.launchpad.net/nova/ and attach the Nova API log if possible. <class 'ConsoleTypeInvalid_Remote'> (HTTP 500) (Request-ID: req-dfd46bc0-fa46-41ea-adda-83929f8f94d8) taget@taget-ThinkStation-P300:~/devstack$ nova get-vnc-console testvm spice-html5 ERROR (ClientException): Unexpected API Error. Please report this at http://bugs.launchpad.net/nova/ and attach the Nova API log if possible. <class 'ConsoleTypeInvalid_Remote'> (HTTP 500) (Request-ID: req-61028912-7436-4ac5-9217-13813f55f7fa) taget@taget-ThinkStation-P300:~/devstack$ nova get-vnc-console testvm serial ERROR (ClientException): Unexpected API Error. Please report this at http://bugs.launchpad.net/nova/ and attach the Nova API log if possible. <class 'ConsoleTypeInvalid_Remote'> (HTTP 500) (Request-ID: req-5f83283d-9b75-40b1-9dae-81cf30890749) taget@taget-ThinkStation-P300:~/devstack$ nova get-vnc-console testvm webmks ERROR (ClientException): Unexpected API Error. Please report this at http://bugs.launchpad.net/nova/ and attach the Nova API log if possible. <class 'ConsoleTypeInvalid_Remote'> (HTTP 500) (Request-ID: req-ec419562-f7c2-43ed-9d61-333633f45e5d) 3. Reproduce steps: create a testvm(default configurtion) with nova boot bla bla bla .. nova get-vnc-console testvm webmks Expected result: HTTP 400, bad request Invalid console type %(console_type)s" Actual result: HTTP 500 To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1551104/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
