** Also affects: tap-as-a-service
Importance: Undecided
Status: New
** Changed in: tap-as-a-service
Assignee: (unassigned) => Reedip (reedip-banerjee)
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1532258
Title:
neutronclient commands do not follow cliff command guideline
Status in neutron:
Fix Released
Status in python-neutronclient:
Fix Released
Status in tap-as-a-service:
In Progress
Bug description:
The docstring of cliff.command.Command says that developers
implementing commands should override take_action instead of run [1].
neutornclient DeleteCommand and UpdateCommand override run().
take_action() should be used.
In addition, neutronclient.common.command.OpenStackCommand provides an
extra and meaningless layer and interface get_data(). get_data()
provides no addition value. take_action() should be used.
CreateCommand, ShowCommand and ListCommand are affected.
[1]
https://github.com/openstack/cliff/blob/master/cliff/command.py#L39-L52
To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1532258/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : [email protected]
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
