Reviewed: https://review.openstack.org/291259 Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=dc68662a0be831b66fc50d6bca7a8f1d70351200 Submitter: Jenkins Branch: master
commit dc68662a0be831b66fc50d6bca7a8f1d70351200 Author: Hirofumi Ichihara <[email protected]> Date: Fri Mar 11 00:49:06 2016 +0900 Fix PUT tag failure This patch fix failure putting tag on network. Timestamp causes the issue because it try to update 'updated_at' of tag which doesn't have the attribute. Change-Id: Iad088bbaf4b05a25153964ed30762b70fc8b3318 Closes-Bug: #1555686 ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1555686 Title: Can't PUT tag on network Status in neutron: Fix Released Bug description: Tag update fails. $ neutron net-create test-network $ neutron tag-add --resource-type network --resource test-network --tag test-tag Request Failed: internal server error while processing your request. Neutron server returns request_ids: ['req-ccb9c3ec-6cdc-4638-b096-32e082b56bdc'] Error log: 2016-03-10 15:33:52.744 ERROR neutron.api.v2.resource [req-ccb9c3ec-6cdc-4638-b096-32e082b56bdc demo 83ff410076214c88ad045e59e9e9e95f] update failed 2016-03-10 15:33:52.744 TRACE neutron.api.v2.resource Traceback (most recent call last): 2016-03-10 15:33:52.744 TRACE neutron.api.v2.resource File "/opt/stack/neutron/neutron/api/v2/resource.py", line 84, in resource 2016-03-10 15:33:52.744 TRACE neutron.api.v2.resource result = method(request=request, **args) 2016-03-10 15:33:52.744 TRACE neutron.api.v2.resource File "/opt/stack/neutron/neutron/extensions/tag.py", line 104, in update 2016-03-10 15:33:52.744 TRACE neutron.api.v2.resource return self.plugin.update_tag(request.context, parent, parent_id, id) 2016-03-10 15:33:52.744 TRACE neutron.api.v2.resource File "/usr/local/lib/python2.7/dist-packages/oslo_log/helpers.py", line 46, in wrapper 2016-03-10 15:33:52.744 TRACE neutron.api.v2.resource return method(*args, **kwargs) 2016-03-10 15:33:52.744 TRACE neutron.api.v2.resource File "/opt/stack/neutron/neutron/services/tag/tag_plugin.py", line 99, in update_tag 2016-03-10 15:33:52.744 TRACE neutron.api.v2.resource context.session.add(tag_db) 2016-03-10 15:33:52.744 TRACE neutron.api.v2.resource File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/orm/session.py", line 490, in __exit__ 2016-03-10 15:33:52.744 TRACE neutron.api.v2.resource self.rollback() 2016-03-10 15:33:52.744 TRACE neutron.api.v2.resource File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/util/langhelpers.py", line 60, in __exit__ 2016-03-10 15:33:52.744 TRACE neutron.api.v2.resource compat.reraise(exc_type, exc_value, exc_tb) 2016-03-10 15:33:52.744 TRACE neutron.api.v2.resource File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/orm/session.py", line 487, in __exit__ 2016-03-10 15:33:52.744 TRACE neutron.api.v2.resource self.commit() 2016-03-10 15:33:52.744 TRACE neutron.api.v2.resource File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/orm/session.py", line 392, in commit 2016-03-10 15:33:52.744 TRACE neutron.api.v2.resource self._prepare_impl() 2016-03-10 15:33:52.744 TRACE neutron.api.v2.resource File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/orm/session.py", line 372, in _prepare_impl 2016-03-10 15:33:52.744 TRACE neutron.api.v2.resource self.session.flush() 2016-03-10 15:33:52.744 TRACE neutron.api.v2.resource File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/orm/session.py", line 2019, in flush 2016-03-10 15:33:52.744 TRACE neutron.api.v2.resource self._flush(objects) 2016-03-10 15:33:52.744 TRACE neutron.api.v2.resource File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/orm/session.py", line 2046, in _flush 2016-03-10 15:33:52.744 TRACE neutron.api.v2.resource self.dispatch.before_flush(self, flush_context, objects) 2016-03-10 15:33:52.744 TRACE neutron.api.v2.resource File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/event/attr.py", line 218, in __call__ 2016-03-10 15:33:52.744 TRACE neutron.api.v2.resource fn(*args, **kw) 2016-03-10 15:33:52.744 TRACE neutron.api.v2.resource File "/opt/stack/neutron/neutron/services/timestamp/timestamp_db.py", line 74, in update_timestamp 2016-03-10 15:33:52.744 TRACE neutron.api.v2.resource obj.standard_attr.updated_at = timeutils.utcnow() 2016-03-10 15:33:52.744 TRACE neutron.api.v2.resource AttributeError: 'NoneType' object has no attribute 'updated_at' To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1555686/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
