Reviewed: https://review.openstack.org/290800 Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=05b53f7d60c2e9e0c7538348656442a89a03d3fd Submitter: Jenkins Branch: master
commit 05b53f7d60c2e9e0c7538348656442a89a03d3fd Author: Tyr Johanson <[email protected]> Date: Wed Mar 9 12:22:44 2016 -0700 Images Actions Return Promises The Angular images actions now consistently return a promise. This allows a view to fetch an image related action from the registry, call it, and have a consistent way to know that it is complete. For actions, promises are preferred over events because they require less setup and teardown, better handle the asynchronous nature of modals, don't require a parent-child scope relationship and finally allow for success/fail handler chaining. Future patches may add data to the promise so that the view can know which items were affected by the action. This patch simply returns promises from actions as this is a pattern I'd like to establish for Mitaka. Usage of these promises is left to a follow-on patch. Also, removing the event mechanism from actions is left to a follow-on patch. Change-Id: I78d189d6eb026bd98abba6451641010104fc5002 Partially-Implements: blueprint angularize-images-table Closes-Bug: 1555929 Partial-Bug: 1514627 ** Changed in: horizon Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1555929 Title: Actions directive / delete action hides completion Status in OpenStack Dashboard (Horizon): Fix Released Bug description: The angular actions directive and delete service invoke promises, but don't return back a handle back to the promise. This prevents tables using them from just using the standard promise mechanism to know when the action completes. This is especially problematic for making actions truly reusable and blocks the search table from knowing when something completed. To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1555929/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
