Reviewed: https://review.openstack.org/293127
Committed:
https://git.openstack.org/cgit/openstack/nova/commit/?id=ae6d868e2f13f90d9f97c982fdbbccdc6fb8b9c9
Submitter: Jenkins
Branch: master
commit ae6d868e2f13f90d9f97c982fdbbccdc6fb8b9c9
Author: Diana Clarke <diana.joan.cla...@gmail.com>
Date: Tue Mar 15 16:17:28 2016 -0400
Fix retry mechanism for generator results
Both v1 and v2 of the glance client return python generators in some
cases (rather than fully fleshed out lists) which thwarts our retry
mechanism. Convert generator results to a list, so that any potential
exceptions get raised earlier rather than later, allowing for retries.
Change-Id: Ibc84f1596d4eaabdef0a48f6cf4da2d1323843a8
Closes-Bug: #1557584
** Changed in: nova
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1557584
Title:
Broken retry mechanism for 'nova image-list'
Status in OpenStack Compute (nova):
Fix Released
Bug description:
You can configure a list of glance API servers in nova.conf like so:
[glance]
api_servers=http://192.168.122.30:9292/v1,http://192.168.122.31:9292/v1
num_retries = 5
When a call to one of the glance api servers fails, nova typically
retries the call on one of the others. This is not the case for 'nova
image-list'.
The retry mechanism is here:
https://github.com/openstack/nova/blob/83261f3106a8bdde38d258a74da777add4956290/nova/image/glance.py#L249
In the case of 'nova image-list', glanceclient returns a python
generator rather than an actual list of images. Because a generator is
returned, an exception will never be raised there, so the retry
mechanism is never executed.
https://github.com/openstack/python-
glanceclient/blob/d59e341a4cd99a8488d5cf41052d9b218379ac87/glanceclient/v1/images.py#L268
This bug was originally reported downstream:
https://bugzilla.redhat.com/show_bug.cgi?id=1313254
To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1557584/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
