Reviewed: https://review.openstack.org/294560 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=29fb0aca1623eb0c4a565d728501667a4c5e8136 Submitter: Jenkins Branch: master
commit 29fb0aca1623eb0c4a565d728501667a4c5e8136 Author: Matthew Booth <[email protected]> Date: Fri Mar 18 12:12:51 2016 +0000 Fix conversion of config disks to qcow2 during resize/migration finish_migration contains some code which converts raw disks to qcow2 when moving from a host which uses raw disks to a host which uses qcow2 disks. This was erroneously also converted config disks, which are hard-coded to be raw even when other disks are qcow2. This has always been broken, but it wasn't previously exposed because a subsequent bug unconditionally overwrote the qcow2 config disk with a new, raw one. Change I03e08fae97416ebe5cdedcf238a06d1b90203c5d changed the order of these 2 events, so that the erroneously-converted config drive was no longer overwritten, resulting in a qcow2 file being presented to the instance as raw. This change explicitly filters out config disks from conversion. Change-Id: I6bf3cd4f9e0e152bf69732d9a17f93c86dedbd40 Closes-Bug: #1558343 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1558343 Title: configdrive is lost after resize.(libvirt driver) Status in OpenStack Compute (nova): Fix Released Status in OpenStack Compute (nova) kilo series: Confirmed Status in OpenStack Compute (nova) liberty series: Confirmed Bug description: Used the trunk code as of 2016/03/16 my environment disabled metadata agent and forced the use of config drive. console log before resize: http://paste.openstack.org/show/490825/ console log after resize: http://paste.openstack.org/show/490824/ qemu 18683 1 4 18:40 ? 00:00:32 /usr/bin/qemu-system-x86_64 -name instance-00000002 -S -machine pc-i440fx-2.0,accel=tcg,usb=off -m 128 -realtime mlock=off -smp 1,sockets=1,cores=1,threads=1 -uuid 018892c7-8144-49c0-93d2-79ee83efd6a9 -smbios type=1,manufacturer=OpenStack Foundation,product=OpenStack Nova,version=13.0.0,serial=16c127e2-6369-4e19-a646-251a416a8dcd,uuid=018892c7-8144-49c0-93d2-79ee83efd6a9,family=Virtual Machine -no-user-config -nodefaults -chardev socket,id=charmonitor,path=/var/lib/libvirt/qemu/domain-instance-00000002/monitor.sock,server,nowait -mon chardev=charmonitor,id=monitor,mode=control -rtc base=utc -no-shutdown -boot strict=on -device piix3-usb-uhci,id=usb,bus=pci.0,addr=0x1.0x2 -drive file=/opt/stack/data/nova/instances/018892c7-8144-49c0-93d2-79ee83efd6a9/disk,if=none,id=drive-virtio-disk0,format=qcow2,cache=none -device virtio-blk-pci,scsi=off,bus=pci.0,addr=0x4,drive=drive-virtio-disk0,id=virtio-disk0,bootindex=1 -drive file=/opt/stack/da ta/nova/instances/018892c7-8144-49c0-93d2-79ee83efd6a9/disk.config,if=none,id=drive-ide0-1-1,readonly=on,format=raw,cache=none -device ide-cd,bus=ide.1,unit=1,drive=drive-ide0-1-1,id=ide0-1-1 -netdev tap,fd=23,id=hostnet0 -device virtio-net-pci,netdev=hostnet0,id=net0,mac=fa:16:3e:34:d6:f3,bus=pci.0,addr=0x3 -chardev file,id=charserial0,path=/opt/stack/data/nova/instances/018892c7-8144-49c0-93d2-79ee83efd6a9/console.log -device isa-serial,chardev=charserial0,id=serial0 -chardev pty,id=charserial1 -device isa-serial,chardev=charserial1,id=serial1 -vnc 127.0.0.1:1 -k en-us -device cirrus-vga,id=video0,bus=pci.0,addr=0x2 -device virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x5 -msg timestamp=on $ blkid /dev/vda1: LABEL="cirros-rootfs" UUID="d42bb4a4-04bb-49b0-8821-5b813116b17b" TYPE="ext3" $ another vm without resize: $ blkid /dev/vda1: LABEL="cirros-rootfs" UUID="d42bb4a4-04bb-49b0-8821-5b813116b17b" TYPE="ext3" /dev/sr0: LABEL="config-2" TYPE="iso9660" $ To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1558343/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
