Reviewed: https://review.openstack.org/271959 Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=9db81351ed8ddeeb279f640eccbdf539945bde7f Submitter: Jenkins Branch: master
commit 9db81351ed8ddeeb279f640eccbdf539945bde7f Author: Hong Hui Xiao <[email protected]> Date: Mon Jan 25 04:09:48 2016 -0500 Fix wrong use of list of dict in _check_driver_to_bind From [1], the segments_to_bind should be a list of dict, so the "level.segment_id in segments_to_bind" will never work. This patch extracts a set of segment ids and uses the set in the if condition. [1] https://goo.gl/yKYSTA Change-Id: I58f1d128e6cd79546d84f7d5bfcb026affc4fc5e Closes-bug: #1524356 ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1524356 Title: a level binding implement issue in _check_driver_to_bind Status in neutron: Fix Released Bug description: in the function of _check_driver_to_bind, the below row 3 condition will never be satisfied. the type of Level.segment_id is string, but Segment_to_bind is a list dict. 1 for level in binding_levels: 2 if (level.driver == driver and 3 level.segment_id in segments_to_bind): 4 return False To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1524356/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
