Reviewed: https://review.openstack.org/244372 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=5c011418a23366020118f096c2943eef8100726a Submitter: Jenkins Branch: master
commit 5c011418a23366020118f096c2943eef8100726a Author: Stephen Finucane <[email protected]> Date: Thu Nov 12 00:13:16 2015 +0000 test_fields: Remove all 'Enum' subclass tests All functionality in these tests is already validated in test for the 'Enum' superclass tests. There is no need to validate it again. Delete these tests. Change-Id: I8334c53674edd937caa058136473d8584233ffaa Closes-Bug: #1515405 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1515405 Title: 'Enum' field tests provide little value Status in OpenStack Compute (nova): Fix Released Bug description: There are tests for a number of 'Enum'-type fields found in the below file: https://github.com/openstack/nova/blob/5beca6f332044904156b80a4c395a43a000f4413/nova/tests/unit/objects/test_fields.py#L328 However, it makes little sense to test the implementations of the Enum field when we can (and do) validate the base class. The only reason for retaining the tests appears to be to maintain versioning, but 'test_objects.py' takes care of this for us. Therefore, we should delete the tests and thus reduce both the LOC count and the amount of new code folks need to write when adding new fields. To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1515405/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
