Reviewed: https://review.openstack.org/297210 Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=193aa35325b897b960de88b510181b377e4c345c Submitter: Jenkins Branch: master
commit 193aa35325b897b960de88b510181b377e4c345c Author: Ihar Hrachyshka <[email protected]> Date: Thu Mar 24 16:16:17 2016 +0100 firewall: don't warn about a driver that does not accept bridge Drivers that do not need the bridge parameter are safe to ignore it. Actually, the base abstract interface for those drivers does not allow to pass the new parameter. Ideally, the base class __init__ signature would change to accept the argument, but we can't do it without breaking API. So instead, just handle both types of drivers - those that accept the additional argument, and those that don't. And don't assume the latter are somehow wrong. Change-Id: Iceee46f63669b28e3a34d207216d864f1bfa5cf8 Closes-Bug: #1561243 ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1561243 Title: Integration bridge parameter leaking into IptablesFirewallDriver Status in neutron: Fix Released Bug description: The following warning appears when starting the Linux bridge agent with the neutron.agent.linux.iptables_firewall.IptablesFirewallDriver firewall driver: 2016-03-23 23:09:10.987 3322 WARNING neutron.agent.securitygroups_rpc [req-4760542b-15dc-4f1f-ac26-b211d8a78e91 - - - - -] Firewall driver neutron.agent.linux.iptables_firewall.IptablesFirewallDriver doesn't accept integration_bridge parameter in __init__(): __init__() got an unexpected keyword argument 'integration_bridge' The integration bridge parameter should only apply to the neutron.agent.linux.iptables_firewall.OVSHybridIptablesFirewallDriver firewall driver. To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1561243/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
