Reviewed: https://review.openstack.org/302946 Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=5cdd7ae574312a7499a8768c1752d9bc27ff7d20 Submitter: Jenkins Branch: master
commit 5cdd7ae574312a7499a8768c1752d9bc27ff7d20 Author: Oleg Bondarev <[email protected]> Date: Thu Apr 7 19:27:38 2016 +0300 Values for [ml2]/physical_network_mtus should not be unique Obviously there could be physical networks with same MTU. The patch sets unique_values to False when parsing physical_network_mtus Unit test added. Closes-Bug: #1567502 Change-Id: I46e5b5d3f7033a974fca40342af6dff7c71a9a4a ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1567502 Title: [ml2]/physical_network_mtus impoperly handled Status in neutron: Fix Released Bug description: We're using [ml2]/physical_network_mtus to specify mappings like this one: [ml2] physical_network_mtus = physnet1:1500,physnet2:1500 In this try/except https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/helpers.py#L37: try: self.physnet_mtus = utils.parse_mappings( cfg.CONF.ml2.physical_network_mtus ) except Exception: self.physnet_mtus = [] if you specify the option above, neutron.common.utils.parse_mappings fails with: ValueError: Value 1500 in mapping: 'physnet2:1500' not unique That's because you need to call neutron.common.utils.parse_mappings with unique_values=False To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1567502/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
