Reviewed: https://review.openstack.org/272471 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=4ad414f3b1216393301ef268a64e61ca1a3d5be9 Submitter: Jenkins Branch: master
commit 4ad414f3b1216393301ef268a64e61ca1a3d5be9 Author: Kevin_Zheng <[email protected]> Date: Tue Jan 26 18:51:29 2016 +0800 Add checks for driver attach_interfaces capability Currently Ironic driver does not support attach interfaces for instances, and the error of NotImplementedError has not been handled. Accodring to the comments of the previous patchset 3, a better solution of this problem will be add a check of driver capability before the actual interface attach job, as it won't have the problem of orphan port [1] This patch addes checks for driver attach interface capabalities. [1] https://review.openstack.org/#/c/272471/3/nova/compute/manager.py Change-Id: I3fa376f866e70e1b90a6aa10b1fe6b169a0ffa43 Closes-Bug: #1538054 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1538054 Title: attach_interface in nova.compute.manager didn't handle NotImplemented Error Status in OpenStack Compute (nova): Fix Released Bug description: In https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L4958~L4965 we handled only exception.NovaException but we didn't handle NotImplemented Error, but since ironic driver didn't support this method, so NotImplemented Error will raise, we need to handle it. To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1538054/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
