Reviewed: https://review.openstack.org/301862 Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=037d1c0927b64848ea0934990ba6538d9d7a8133 Submitter: Jenkins Branch: master
commit 037d1c0927b64848ea0934990ba6538d9d7a8133 Author: David Lyle <[email protected]> Date: Wed Mar 16 10:25:26 2016 -0600 removing httplib2 test dependency Once upon a time, the python-*client libraries were primarily built to use httplib2. They have subsequently shift to using requests and thus urllib3. The horizon test helpers code was maintaining a reference to httplib2 as it intercepted errant library calls that were not mocked. httplib2 is not actively maintained and OpenStack is moving to remove it as a dependency. See http://lists.openstack.org/pipermail/openstack-dev/2016-March/089225.html for more details. This patch removed the httplib2 dependency. Upon removing the dependency it exposed a missed update from httplib2 to urllib3. A function that was intended to catch unmocked calls was only listening for httplib2 connections. This patch updates that failsafe to work with urllib3. Upon doing so, it pointed out many, many missing mocks and in turn, many broken tests that appeared to work because of API call failures. This patch adds the missing mocks and fixes the broken tests. The new failsafe prints the stack trace when an outside connection is attempted. Additionally, to fix the fact that a missed mock used to allow tests to potentially pass, as documented by bug 1517704, a test failure is now forced on tests where a missing mock is detected. Closes-Bug: #1517704 Implements blueprint: remove-httplib2-dep Change-Id: Iaabdf03966c14c82e0c58a3b1ab1a6755c05adcb ** Changed in: horizon Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1517704 Title: Test still passes even with tests failure Status in OpenStack Dashboard (Horizon): Fix Released Bug description: Tests seems still to pass even with test failures. There are two tests failure on the code, and test run still report it passes: https://bugs.launchpad.net/horizon/+bug/1517670 https://bugs.launchpad.net/horizon/+bug/1517653 To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1517704/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
