Reviewed: https://review.openstack.org/280472 Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=f195fea9390f7650c372b3e749c1ad0342e72036 Submitter: Jenkins Branch: master
commit f195fea9390f7650c372b3e749c1ad0342e72036 Author: Alan Fung <[email protected]> Date: Mon Feb 15 18:01:13 2016 -0800 Fix issue with some modals are missing backdrop Some modal views are inheriting from ModalFormMixin directly instead of from ModalFormView (i.e. NonMembersView). This causes inconsistency with some modal does not have a backdrop (not inheriting ModalBackdropMixin). There are 7 places that inherit from ModalFormView directly now, and they appear to be needing a backdrop; it'd be logical that ModalFormMixin inherit from ModalBackdropMixin. Change-Id: Id878a82341c8e84d5c0ca798aa648a8e7940df0e Closes-Bug: #1545892 ** Changed in: horizon Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1545892 Title: Missing backdrop on "Add Group Assignment" modal Status in OpenStack Dashboard (Horizon): Fix Released Bug description: All if not most modal have semi-opaque backdrops. The Add-Group- Assignment modal does not have one. Reproduce: 1. Go to Identity > Groups. 2. Click click "Manage Members" for any particular group from the table. 3. Click on "Add Users". Expected: Has a semi-opaque backdrop behind the modal. Actual: Has no semi-opaque backdrop behind the modal. To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1545892/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
