Reviewed: https://review.openstack.org/320248 Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=abdb8585a0634a39dbc135aaa5e7ea296f426bea Submitter: Jenkins Branch: master
commit abdb8585a0634a39dbc135aaa5e7ea296f426bea Author: Hong Hui Xiao <[email protected]> Date: Tue May 24 07:09:02 2016 +0000 Remove the inaccurate help message for min_l3_agents_per_router Trival fix Change-Id: If9b1785995336235a3bdf82ab451f50ab4e0793d Closes-bug: #1585078 ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1585078 Title: The help message for min_l3_agents_per_router is not accurate Status in neutron: Fix Released Bug description: [1] says that the min_l3_agents_per_router could be 0, but when set it to 0, neutron server will report 2016-05-24 06:50:30.004 TRACE neutron File "/opt/stack/neutron/neutron/services/l3_router/l3_router_plugin.py", line 66, in __init__ 2016-05-24 06:50:30.004 TRACE neutron super(L3RouterPlugin, self).__init__() 2016-05-24 06:50:30.004 TRACE neutron File "/opt/stack/neutron/neutron/db/l3_hamode_db.py", line 186, in __init__ 2016-05-24 06:50:30.004 TRACE neutron self._verify_configuration() 2016-05-24 06:50:30.004 TRACE neutron File "/opt/stack/neutron/neutron/db/l3_hamode_db.py", line 171, in _verify_configuration 2016-05-24 06:50:30.004 TRACE neutron self._check_num_agents_per_router() 2016-05-24 06:50:30.004 TRACE neutron File "/opt/stack/neutron/neutron/db/l3_hamode_db.py", line 183, in _check_num_agents_per_router 2016-05-24 06:50:30.004 TRACE neutron raise l3_ha.HAMinimumAgentsNumberNotValid() 2016-05-24 06:50:30.004 TRACE neutron HAMinimumAgentsNumberNotValid: min_l3_agents_per_router config parameter is not valid. It has to be equal to or more than 2 for HA. There is even an UT for min_l3_agents_per_router to be 0 at [2]. We should remove the help message. [1] https://github.com/openstack/neutron/blob/557a2d9ece94eedc56bebf554be3f9ffda46186a/neutron/db/l3_hamode_db.py#L67-L68 [2] https://github.com/openstack/neutron/blob/557a2d9ece94eedc56bebf554be3f9ffda46186a/neutron/tests/unit/db/test_l3_hamode_db.py#L119 To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1585078/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
