Reviewed: https://review.openstack.org/317462 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=5baca35e35502eec61aea9d8557bda465fe92170 Submitter: Jenkins Branch: master
commit 5baca35e35502eec61aea9d8557bda465fe92170 Author: Zhenguo Niu <[email protected]> Date: Tue May 17 21:17:12 2016 +0800 [Ironic] Correct check for ready to deploy Currently the check for whether the node is ready to deploy is useless as it will always be true. Change-Id: Ied0722737c127ed02dcac9bd304fd388d58e6d82 Closes-Bug: #1582680 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1582680 Title: Ironic: wrong check for ready to deploy Status in OpenStack Compute (nova): Fix Released Bug description: In ironic driver, before really do deploy, we will first validate whether the node is ready to deploy by calling ironic node.validate method. # validate we are ready to do the deploy validate_chk = self.ironicclient.call("node.validate", node_uuid) if not validate_chk.deploy or not validate_chk.power: # something is wrong. undo what we have done Here, the condition validte_chk.deploy and validate_chk.power will always be true, as they are dict like {deploy: {reason: "xxxx", result: False}, power: {result: False}} so we should change to check validate_chk.deploy.get('result') and validate_chk.power.get('result'). To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1582680/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
