Reviewed: https://review.openstack.org/322372 Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=5109d16bc52abb20636c94c0208fb498d1c626eb Submitter: Jenkins Branch: master
commit 5109d16bc52abb20636c94c0208fb498d1c626eb Author: Kevin Benton <[email protected]> Date: Sat May 14 23:44:23 2016 -0700 Make deepcopy of update body in API layer This adjusts the update handler in the API layer to pass a deepcopy of the original update body to ensure that the original is used on any generated retry requests. Without this update handlers that modified the body as they processed it (e.g. the external gateway update for routers) would be missing data on a retry request. This adds a test case for the bug that was caused by this. Closes-Bug: #1584920 Change-Id: I88fb9d45eb82ef48e0d865decdcc7fad1c5fb361 ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1584920 Title: ExternalGatewayForFloatingIPNotFound exception raised in gate-tempest- dsvm-neutron-full Status in neutron: Fix Released Bug description: http://logs.openstack.org/10/316610/3/gate/gate-tempest-dsvm-neutron- full/89ec2d5/logs/testr_results.html.gz Traceback (most recent call last): File "tempest/test.py", line 113, in wrapper return f(self, *func_args, **func_kwargs) File "tempest/scenario/test_network_advanced_server_ops.py", line 112, in test_server_connectivity_reboot server, keypair, floating_ip = self._setup_network_and_servers() File "tempest/scenario/test_network_advanced_server_ops.py", line 65, in _setup_network_and_servers floating_ip = self.create_floating_ip(server, public_network_id) File "tempest/scenario/manager.py", line 858, in create_floating_ip fixed_ip_address=ip4 File "tempest/lib/services/network/floating_ips_client.py", line 21, in create_floatingip return self.create_resource(uri, post_data) File "tempest/lib/services/network/base.py", line 60, in create_resource resp, body = self.post(req_uri, req_post_data) File "tempest/lib/common/rest_client.py", line 259, in post return self.request('POST', url, extra_headers, headers, body) File "tempest/lib/common/rest_client.py", line 641, in request resp, resp_body) File "tempest/lib/common/rest_client.py", line 694, in _error_checker raise exceptions.NotFound(resp_body, resp=resp) tempest.lib.exceptions.NotFound: Object not found Details: {u'type': u'ExternalGatewayForFloatingIPNotFound', u'detail': u'', u'message': u'External network 2698f174-8255-4521-927a-4d70212c3e94 is not reachable from subnet a7516d4c-3c9a-48c0-97ee-83059e727294. Therefore, cannot associate Port f73aa386-f1b3-4f88-bcf4-c2e03a565d15 with a Floating IP.'} http://logs.openstack.org/09/312009/11/gate/gate-tempest-dsvm-neutron- full/0b89afa/logs/testr_results.html.gz Traceback (most recent call last): File "tempest/test.py", line 112, in wrapper return f(self, *func_args, **func_kwargs) File "tempest/scenario/test_network_basic_ops.py", line 398, in test_network_basic_ops self._setup_network_and_servers() File "tempest/scenario/test_network_basic_ops.py", line 123, in _setup_network_and_servers floating_ip = self.create_floating_ip(server) File "tempest/scenario/manager.py", line 858, in create_floating_ip fixed_ip_address=ip4 File "tempest/lib/services/network/floating_ips_client.py", line 21, in create_floatingip return self.create_resource(uri, post_data) File "tempest/lib/services/network/base.py", line 60, in create_resource resp, body = self.post(req_uri, req_post_data) File "tempest/lib/common/rest_client.py", line 260, in post return self.request('POST', url, extra_headers, headers, body) File "tempest/lib/common/rest_client.py", line 649, in request resp, resp_body) File "tempest/lib/common/rest_client.py", line 747, in _error_checker raise exceptions.NotFound(resp_body, resp=resp) tempest.lib.exceptions.NotFound: Object not found Details: {u'message': u'External network bbb07097-8453-41ed-b9fc-a017f5bf7c20 is not reachable from subnet e1dcd01e-5a58-498a-b2a7-58167fd67e76. Therefore, cannot associate Port 603843ca-f04a-4301-9582-4a359e5db66a with a Floating IP.', u'detail': u'', u'type': u'ExternalGatewayForFloatingIPNotFound'} To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1584920/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
