Reviewed: https://review.openstack.org/326262 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=adcc0e418b7d880a0b0bd60ea9d0ef1e2ef4e67e Submitter: Jenkins Branch: master
commit adcc0e418b7d880a0b0bd60ea9d0ef1e2ef4e67e Author: Rajesh Tailor <[email protected]> Date: Tue Jun 7 07:05:11 2016 +0000 Revert "Optimize _cleanup_incomplete_migrations periodic task" The change modified instance filtering condition, which filters all deleted instances on current host, which is not as expected by periodic task. The periodic task expects instances, whose instance uuid are associated with migration record. And after filtering we only need to apply the instance deletion logic on instance files where instance.host is not set as current host (CONF.host). This reverts commit 099cf53925c0a0275325339f21932273ee9ce2bc. Change-Id: Ic71c939bef86f1e5cb485c6827c69c3d638f2e89 Closes-Bug: 1589821 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1589821 Title: cleanup_incomplete_migrations periodic task regression with commit 099cf53925c0a0275325339f21932273ee9ce2bc Status in OpenStack Compute (nova): Fix Released Status in OpenStack Compute (nova) mitaka series: In Progress Bug description: Patch [1] changes the instance filtering condition in periodic task "cleanup_incomplete_migrations" introduced in [2], in such a way that it generates new issue, [3] After change [1] lands, the condition changes filtering logic, so now all instances on current host are filtered, which is not expected. We should filter all instances where instance uuids are associated with migration records and those migration status is set to 'error' and instance is marked as deleted. [1] https://review.openstack.org/#/c/256102/ [2] https://review.openstack.org/#/c/219299/ [2] https://bugs.launchpad.net/nova/+bug/1586309 To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1589821/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
