Reviewed: https://review.openstack.org/327836 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=4e5015f228b789fadf8c1c551302158debe8f0a5 Submitter: Jenkins Branch: master
commit 4e5015f228b789fadf8c1c551302158debe8f0a5 Author: Andrew Laski <[email protected]> Date: Thu Jun 9 13:33:37 2016 -0400 Replace mox with mock for xenapi vm_utils.lookup The py34 check jobs are failing occasionally when trying to use mox on the vm_utils.lookup method, seemingly because it is not restored properly at some point. Rather than chase that down this patch replaces the usage of mox with mock for patching this method. Change-Id: I3f36b72ab435dea224eb61d449e13ae80d9b61a8 Closes-Bug: 1590896 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1590896 Title: py34 intermittent xenapi test failures Status in OpenStack Compute (nova): Fix Released Bug description: From http://logs.openstack.org/24/322324/5/check/gate-nova- python34-db/f5fadd6/console.html 2016-06-08 22:33:44.530 | nova.tests.unit.virt.xenapi.test_vmops.VMOpsTestCase.test_finish_revert_migration_after_crash_before_new 2016-06-08 22:33:44.530 | -------------------------------------------------------------------------------------------------------- 2016-06-08 22:33:44.530 | 2016-06-08 22:33:44.531 | Captured traceback: 2016-06-08 22:33:44.531 | ~~~~~~~~~~~~~~~~~~~ 2016-06-08 22:33:44.531 | b'Traceback (most recent call last):' 2016-06-08 22:33:44.531 | b' File "/home/jenkins/workspace/gate-nova-python34-db/nova/tests/unit/virt/xenapi/test_vmops.py", line 126, in test_finish_revert_migration_after_crash_before_new' 2016-06-08 22:33:44.531 | b' self._test_finish_revert_migration_after_crash(True, False)' 2016-06-08 22:33:44.531 | b' File "/home/jenkins/workspace/gate-nova-python34-db/nova/tests/unit/virt/xenapi/test_vmops.py", line 97, in _test_finish_revert_migration_after_crash' 2016-06-08 22:33:44.531 | b" self.mox.StubOutWithMock(vm_utils, 'lookup')" 2016-06-08 22:33:44.531 | b' File "/home/jenkins/workspace/gate-nova-python34-db/.tox/py34/lib/python3.4/site-packages/mox3/mox.py", line 321, in StubOutWithMock' 2016-06-08 22:33:44.531 | b" raise TypeError('Cannot mock a MockAnything! Did you remember to '" 2016-06-08 22:33:44.531 | b'TypeError: Cannot mock a MockAnything! Did you remember to call UnsetStubs in your previous test?' 2016-06-08 22:33:44.531 | b'' This failure has happened to me a few times now on Jenkins jobs but does not reproduce locally. I suspect an ordering issue in the tests, especially since it's not always the same method that fails. To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1590896/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
