Reviewed: https://review.openstack.org/329304 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=4cb366f831d54a0ca80d1f946eb25e862364d566 Submitter: Jenkins Branch: master
commit 4cb366f831d54a0ca80d1f946eb25e862364d566 Author: melanie witt <[email protected]> Date: Tue Jun 14 03:39:57 2016 +0000 Disallow instance tag set for invalid instance states Currently, instance tags can be set at any time during the instance lifecycle, possibly because it does not go through the compute API. This makes the valid instance states for the instance tag update API consistent with the instance metadata update API. If instance tag update is requested outside of the valid states, a 409 conflict error will be returned. Closes-Bug: #1591381 Change-Id: Id53a31654e105854f4942e6d47a1bea90a3e9c3b ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1591381 Title: Instance tags can be set before an instance is active Status in OpenStack Compute (nova): Fix Released Bug description: As opposed to metadata or other attributes of an instance tags can be set very early in the instance lifecycle. This will eventually lead to issues if the boot process makes use of these tags because setting them before boot will be a race condition. And there is a proposed spec which intends to do exactly that, use tags in the scheduling process. To be consistent and to avoid future racy behavior instance tags should only be settable after a boot request after it has gone to ACTIVE status. Passing instance tags in as part of the boot request would be desirable behavior but requires a spec and is outside the scope of this bug. To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1591381/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
