Reviewed: https://review.openstack.org/296543 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=a45f5dd7021a15064ae50d07755be9e2bfc22ae9 Submitter: Jenkins Branch: master
commit a45f5dd7021a15064ae50d07755be9e2bfc22ae9 Author: Corey Wright <[email protected]> Date: Wed Mar 23 10:07:59 2016 -0500 cinder: accommodate v1 cinder client in detach call Call Cinder client's detach() with attachment_uuid only if the client is v2. Cinder client v2 supports passing volume_id and optionally attachment_id to its volume manager's detach() method, but v1 does not, only accepting volume_id. Change I3cdc4992 indiscriminately passes both volume_id and attachment_id to the Cinder client regardless of its version, prompting with v1: TypeError: detach() takes exactly 2 arguments (3 given) Change-Id: I2e8b5947521d659e930141b0b8e6a6353e9163bd Closes-Bug: 1561056 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1561056 Title: cinder volume driver's detach() causes TypeError exception on v1 cinder client Status in OpenStack Compute (nova): Fix Released Status in nova package in Ubuntu: New Bug description: Nova version: git master branch's HEAD (as of today) Expected behavior: cinderclient v1 detach() called with accepted argument Actual behavior: cinderclient v1 detach() called with too many arguments Change I3cdc4992 indiscriminately passes both volume_id and attachment_id to the Cinder client regardless of its version even though Cinder client v2 supports passing volume_id and optionally attachment_id to its volume manager's detach() method, but v1 does not, only accepting volume_id. Calling Cinder client v1 detach() with both volume_id and attachment_id results in "TypeError: detach() takes exactly 2 arguments (3 given)" Full traceback and proposed bug fix to follow. To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1561056/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
