Reviewed: https://review.openstack.org/342707 Committed: https://git.openstack.org/cgit/openstack/python-cinderclient/commit/?id=d2f4b63f647da7c0f1bf36858617ef0e71496cff Submitter: Jenkins Branch: master
commit d2f4b63f647da7c0f1bf36858617ef0e71496cff Author: haobing1 <[email protected]> Date: Fri Jul 15 17:54:30 2016 +0800 Fix string interpolation to delayed to be handled by the logging code String interpolation should be delayed to be handled by the logging code, rather than being done at the point of the logging call. See the oslo i18n guideline. * http://docs.openstack.org/developer/oslo.i18n/guidelines.html Change-Id: I3fa26c1c5c672d5505fa556e03af35318f4774ab Closes-Bug: #1596829 ** Changed in: python-cinderclient Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1596829 Title: String interpolation should be delayed at logging calls Status in Ceilometer: New Status in Glance: In Progress Status in glance_store: New Status in heat: New Status in Ironic: In Progress Status in OpenStack Identity (keystone): New Status in networking-vsphere: Fix Released Status in neutron: Fix Released Status in OpenStack Compute (nova): In Progress Status in os-brick: Fix Released Status in python-cinderclient: Fix Released Status in python-glanceclient: In Progress Status in OpenStack Object Storage (swift): New Status in taskflow: New Bug description: String interpolation should be delayed to be handled by the logging code, rather than being done at the point of the logging call. Wrong: LOG.debug('Example: %s' % 'bad') Right: LOG.debug('Example: %s', 'good') See the following guideline. * http://docs.openstack.org/developer/oslo.i18n/guidelines.html #adding-variables-to-log-messages The rule for it should be added to hacking checks. To manage notifications about this bug go to: https://bugs.launchpad.net/ceilometer/+bug/1596829/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
