Reviewed: https://review.openstack.org/345296 Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=319bc525b408c6df1905e9597da28c2d1ce3020c Submitter: Jenkins Branch: master
commit 319bc525b408c6df1905e9597da28c2d1ce3020c Author: Boden R <[email protected]> Date: Thu Jul 21 15:07:41 2016 +0530 isolate test_db_find_column_type_list As per the recent gate failures (see bug), it appears OVSLibTestCase.test_db_find_column_type_list is not isolated and thus its usage of ovsdb's db_list() and db_find() occasionally obtain different results. This patch adds the db_list() and db_find() operations within the test case to run in a transaction so that we get a single snapshot of the db results. In addition this patch undoes the changes from patch set 1 as the initial changes do not appear to address the issue at hand. Change-Id: I312076edb6e11f21347831843758894e11d6f56c Closes-Bug: #1592546 ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1592546 Title: OVSLibTestCase.test_db_find_column_type_list is not isolated Status in neutron: Fix Released Bug description: Spotted in a functional test log: neutron.tests.functional.agent.test_ovs_lib.OVSLibTestCase.test_db_find_column_type_list(vsctl) ----------------------------------------------------------------------------------------------- Captured traceback: ~~~~~~~~~~~~~~~~~~~ Traceback (most recent call last): File "neutron/tests/functional/agent/test_ovs_lib.py", line 395, in test_db_find_column_type_list self.assertEqual(tags_present, len_0_list) File "/opt/stack/new/neutron/.tox/dsvm-functional/local/lib/python2.7/site-packages/testtools/testcase.py", line 411, in assertEqual self.assertThat(observed, matcher, message) File "/opt/stack/new/neutron/.tox/dsvm-functional/local/lib/python2.7/site-packages/testtools/testcase.py", line 498, in assertThat raise mismatch_error testtools.matchers._impl.MismatchError: [{u'tag': 42}, {u'tag': 1}] != [{u'tag': 42}, {u'tag': 1}, {u'tag': 1567}] Note the extra {'tag': 1567}. To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1592546/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
