Reviewed: https://review.openstack.org/319788 Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=95ff46722d195eb894e79b08c5a6eb13082cc799 Submitter: Jenkins Branch: master
commit 95ff46722d195eb894e79b08c5a6eb13082cc799 Author: Hong Hui Xiao <[email protected]> Date: Mon May 23 08:33:55 2016 +0000 Wait for ovsdb_monitor to be active before use it There is a race between ovsdb_monitor becoming active and using ovsdb_monitor. Sometimes, code [1] will be hit at ovs-agent startup. The fix here will block the start of ovsdb_monitor, so that the following code to use the ovsdb_monitor will have ovsdb_monitor be active. [1] https://goo.gl/RJX4I5 Closes-bug: #1584647 Change-Id: I893a3b250339006f50aa003686fb95d7f2465edc ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1584647 Title: "Interface monitor is not active" can be observed at ovs-agent start Status in neutron: Fix Released Bug description: I noticed this error message in neutron-ovs-agent log when start neutron-openvswitch-agent ERROR neutron.agent.linux.ovsdb_monitor [req-a7c7a398-a13b-490e- adf8-c5afb24b4b9c None None] Interface monitor is not active. ovs-agent will start ovsdb_monitor at [1], and first use it at [2]. There is no guarantee that ovsdb_monitor is ready at [2]. So, I can see the error when start neutron-openvswitch-agent. We should block the start to wait for the process to be active, and then use it. Or else, the use of ovsdb_monitor will be meaningless. [1] https://github.com/openstack/neutron/blob/6da27a78f42db00c91a747861eafde7edc6f1fa7/neutron/agent/linux/polling.py#L35 [2] https://github.com/openstack/neutron/blob/6da27a78f42db00c91a747861eafde7edc6f1fa7/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py#L1994 To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1584647/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
