Reviewed: https://review.openstack.org/350953 Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=5264ab966d3db7b1cb698190872cbe6feaf48464 Submitter: Jenkins Branch: master
commit 5264ab966d3db7b1cb698190872cbe6feaf48464 Author: Nam Nguyen Hoai <[email protected]> Date: Fri Aug 5 09:46:43 2016 +0700 Using revision_number to ensure no overlap in *one* network This patch uses revision_number in database. When creating a subnet in a network, the revision_number of the network will be increased. That will prevent overlapping CIDR (overlapping CIDR means some subnets' cidrs are overlapping) on *one* network. Basically, in case of concurrent requests creating subnets on *one* network, only one request successes, other requests needs retrying request. Change-Id: Id6548535075bed87a4b36e1462db546ab9163f29 Closes-Bug: #1532695 ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1532695 Title: Created subnets on ONE network that duplicated CIDR in case of neutron server active-active Status in neutron: Fix Released Bug description: I had three controllers. I found a bug. I can create subnets on one network that duplicated CIDR range AT SAME TIMING How to reproduce: Topology : http://codepad.org/ff0debPB Step 1: Create a network $ neutron net-create test-net Step 2: Create multiple subnets that duplicated CIDR scope Please running commands AT SAME TIMMING - On controller1: $ neutron subnet-create --name test-subnet1 test-net 192.168.100.0/24 - On controller2: $ neutron subnet-create --name test-subnet2 test-net 192.168.100.0/24 After check subnet-list: Running command: $ neutron subnet-list This is the result: http://codepad.org/306Vi90d Running command: $ neutron net-list This is the result: http://codepad.org/AcYRLP4b After check database: This is the result: http://codepad.org/4qRC229P I think. In originally, one command on controller will be fail and we catch a message as following: "Invalid input for operation: Requested subnet with cidr: 192.168.100.0/24 for network: 39cc0850-1eeb-4c85 -bcdc-338a3f1461aa overlaps with another subnet.". But currently, two commands are success To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1532695/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
