Reviewed: https://review.openstack.org/361792 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=c651572d5acd8838b1c1c0be1eeee11414205c57 Submitter: Jenkins Branch: master
commit c651572d5acd8838b1c1c0be1eeee11414205c57 Author: Takashi NATSUME <[email protected]> Date: Mon Aug 29 10:24:20 2016 +0900 Fix MonitorMetric obj_make_compatible The 'obj_make_compatible' method of MonitorMetric object doesn't work properly because conditional expression is not correct. So fix it and add a unit test for it. Change-Id: I9e5e8b975195b8120e6c10398c284d6a2f5efab9 Closes-Bug: #1617859 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1617859 Title: A compatibility issue in the obj_make_compatible method of MonitorMetric object Status in OpenStack Compute (nova): Fix Released Bug description: In the obj_make_compatible method of MonitorMetric object, the 'numa_nodes_values' in 'if' statement should be 'numa_membw_values' ------------------------------------------------------------------------------- class MonitorMetric(base.NovaObject): (snipped...) def obj_make_compatible(self, primitive, target_version): super(MonitorMetric, self).obj_make_compatible(primitive, target_version) target_version = versionutils.convert_version_to_tuple(target_version) if target_version < (1, 1) and 'numa_nodes_values' in primitive: del primitive['numa_membw_values'] ------------------------------------------------------------------------------- https://github.com/openstack/nova/blob/a5cc0be5c658974a4dd2b792e23c381fd8961e23/nova/objects/monitor_metric.py#L52 To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1617859/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
