Reviewed: https://review.openstack.org/375078 Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=2425e6e860932514c963844dfab6d24b023883bf Submitter: Jenkins Branch: master
commit 2425e6e860932514c963844dfab6d24b023883bf Author: Matt Borland <[email protected]> Date: Thu Sep 22 13:40:29 2016 -0600 Fix metadata removal This fixes the case where known metadata types were not being removed upon saving. When trying to apply name changes to the provided value, the work was done out of order, causing the item to be taken out of the 'removed' list. Change-Id: I0058ce369a9616b4c49f3d6d1a54cf69144e2f0c Co-Authored-By: Matt Wood <[email protected]> Closes-Bug: 1618578 ** Changed in: horizon Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1618578 Title: Image metadata deletion doesn't work from the Update Metadata widget Status in OpenStack Dashboard (Horizon): Fix Released Bug description: Deleting image metadata doesn't work from the Update Metadata widget when deleting metadata items that have existing metadata definitions. It works for deleting custom metadata items. Steps to reproduce: Start with the latest master Horizon code as of 8/30/16. - To to Project -> Compute -> Images. - Select the "Update Metadata" button for an image. - If you have metadata definitions defined in your glance installation, you should see categories for existing metadata definitions under "Available Metadata". - Add a metadata item from the "Available Metadata" categories, such as "Common Operating System Properties" -> "OS Version". Give it a value and Save the change. This works fine. - Select the "Update Metadata" button for the same image and note that the metadata item you just added (such as os_version) now appears in the "Existing Metadata" section. - Remove the metadata item and click Save. - No errors are displayed and no errors are written to the Horizon logs. - Select the "Update Metadata" button for the same image and note that the metadata item you just tried to remove is still there. A workaround for this is to enable the angular images feature and use "Edit Image" -> Metadata to delete metadata items. It works fine from that screen. To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1618578/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
