Reviewed: https://review.openstack.org/359402 Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=dfa0682cac93938fc6fe3c0ccfb0640a0a18ee33 Submitter: Jenkins Branch: master
commit dfa0682cac93938fc6fe3c0ccfb0640a0a18ee33 Author: Dharini Chandrasekar <[email protected]> Date: Tue Aug 23 19:59:32 2016 +0000 Fixing inconsistency in Glance store names. The store names used in glance and glance_store are not in sync with each other. This can confuse operators who have to use different names to refer to the same store while setting values for configuration options such as ``store_type_preference`` in glance and configuration option like ``store`` in glance_store. This inconsistency may also confuse developers during code changes, complicating future code changes with respect to this. Mapping store names: ``vmware_datastore`` and ``filesystem`` to ``vmware`` and ``file`` respectively to be in sync with glance_store entry point names and at the same time accommodate backward compatibility for old configuration files that might still be using ``filesystem`` and ``vmware_datastore``. Note: This change applies only when multiple image locations are being used and ``location_strategy`` configuration option is set to ``store_type``. Note: This change does not require a config refresh change. Impact: UpgradeImpact Credit: This patch has a release note authored by Brian Rosmaita Change-Id: I3d8593cdae6780ae721afedcf47dd45afa684f25 Closes-Bug: #1615852 ** Changed in: glance Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to Glance. https://bugs.launchpad.net/bugs/1615852 Title: Store names in Glance not in sync with the store names used in glance_store Status in Glance: Fix Released Bug description: In the file: https://github.com/openstack/glance/blob/master/glance/common/location_strategy/store_type.py#L57-L63, there is a mapping for stores and their corresponding schemes. The store names in this dictionary however is not in sync with the stores actually accepted in glance_store by the ``stores`` configuration option. The key 'vmware_datastore' needs to actually be 'vmware' and 'filesystem' needs to be 'file'. This can confuse operators who have to use different names to refer to the same store while setting values for configuration options such as ``store_type_preference`` in glance and configuration option like ``store`` in glance_store. This inconsistency may also confuse developers during code changes, complicating future code changes with respect to this. To manage notifications about this bug go to: https://bugs.launchpad.net/glance/+bug/1615852/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
