Reviewed: https://review.openstack.org/345145 Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=f9b3bc7b2baeefbeafd810f285c692f6dad3983b Submitter: Jenkins Branch: master
commit f9b3bc7b2baeefbeafd810f285c692f6dad3983b Author: Richard Jones <[email protected]> Date: Thu Jul 21 13:39:27 2016 +1000 Remove use of scope from action service The scope being handed to (and retained on) the action service was being used for two purposes: 1. handing data down to the underlying wizard steps, and 2. receiving data back from the underlying wizard steps. This patch provides a mechanism for passing data down through injection, and removes the need for event-based data return by explicitly passing the captured wizard data to the submit() resolution. It also adds the controller scope to the allowed() and perform() action service handlers to grant access to contextual information without needing to attach state to the service. Change-Id: Ieb293d0a849cd84d15e7aae0a68558fde80fd2c2 Fixes-Bug: 1640049 ** Changed in: horizon Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1640049 Title: Action services retain state, and should not Status in OpenStack Dashboard (Horizon): Fix Released Bug description: AngularJS services are singletons, so storing state on them is dangerous (using the same service twice in a single context will result in that state data being indeterminate). To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1640049/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
