Reviewed: https://review.openstack.org/399786 Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=43e9df85ab286ddee96e9cff97f551781baf70d1 Submitter: Jenkins Branch: master
commit 43e9df85ab286ddee96e9cff97f551781baf70d1 Author: David Lyle <[email protected]> Date: Fri Nov 18 15:02:20 2016 -0700 Rework hardcoded policy in admin dash Since the content in a Dashboard is not hardcoded, having hardcoded policy checks to specific services at the dashboard level is wrong. The Dashboard was designed to evaluate all panels to determine policy so this type of thing could be avoided. This patch moves the content specific policy checks to the panels where they apply. Additionally, this fix uncovered another bug where policy_rules are wrapped in a list regardless of format. This patch adds a check and only wraps where necessary. Change-Id: I79314a45c3c552ebcb3bb7cc881c2467fa009c5d Closes-Bug: #1643013 Closes-Bug: #1643074 ** Changed in: horizon Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1643074 Title: policy check for panels and dashboards don't handle nested policy rules Status in OpenStack Dashboard (Horizon): Fix Released Bug description: The policy_rules property on Panel and Dashboard is intended to handle nested policy rules, where the top level rules are OR'd and the lower level is AND'd. Currently regardless of what is passed in, it's wrapped in another list. There should be a check that policy_rules is not already a list. To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1643074/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
