Reviewed: https://review.openstack.org/395139 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=5c5544203fb49a01c28237d41f1c75692de79644 Submitter: Jenkins Branch: master
commit 5c5544203fb49a01c28237d41f1c75692de79644 Author: jichenjc <[email protected]> Date: Fri Nov 4 06:48:51 2016 +0800 Add more description for rx and tx param Add more description for rx and tx in diagnostics command. Change-Id: Ia4bc5a43a0a90392444dfbe710d6622986bf34b0 Closes-Bug: 1628368 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1628368 Title: nova diagnostics network rx and tx have no units Status in OpenStack Compute (nova): Fix Released Bug description: The current implementation of the diagnostics API provides various standard network counter info. Two of those fields are simply "<ifname>_rx" and "<ifname>_tx" with no units. This is not nice from a usability and self-documentation perspective. I had to read the code to verify they are in fact in octets. The blueprint (https://wiki.openstack.org/wiki/Nova_VM_Diagnostics) indicates that the current implementation is incorrect (or the blueprint should have been updated...): """ Network details The network details will be an array of dictionaries per each virtual NIC. Key Description rx_octets Received octets (Integer) rx_errors Received errors (Integer) rx_drop Received packets dropped (Integer) rx_packets Received packets (Integer) tx_octets Transmitted Octets (Integer) tx_errors Transmit errors (Integer) tx_drop Transmit dropped packets (Integer) tx_packets Transmit packets (Integer) """ To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1628368/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
