Reviewed: https://review.openstack.org/414311 Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=55a25bdfaf066523e1faa4e8124e3c1c40add506 Submitter: Jenkins Branch: master
commit 55a25bdfaf066523e1faa4e8124e3c1c40add506 Author: Daniel Alvarez <[email protected]> Date: Thu Dec 22 19:07:16 2016 +0000 Fix a bug in process_spawn binding on ports process_spawn module is used in netns-cleanup functional tests. This module forks processes which will listen on random ports/sockets. Due to the lack of randomness on how get_free_namespace_port() from net_helpers was used, all forked processes got the same sequence of ports to bind on. This led to a race condition and some stayed alive without actually listening on any port/socket. Also, the ignore_sigterm feature wasn't handled properly and parent always died after a SIGTERM which caused the test to fail when the above condition happened since netns-cleanup wasn't able to find its parent and kill the process which failed to bind. Change-Id: I2f6e1f99eae595e3ea8c10998a7ad3c861a694f4 Closes-Bug: #1652124 ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1652124 Title: netns-cleanup functional test fails on some conditions Status in neutron: Fix Released Bug description: We've seen this functional test failing in the gate [0] and it's due to a bug in the helper module that was written for the functional test. [1] The problem shows up when process_spawn is not able to find a port to listen on and the process stays running anyways. That means that netns-cleanup won't clean it up and this condition [2] doesn't hold (1!=0). As per logs in the gate I can tell that it's only a bug in the functional test but not in the module itself. I myself will submit a patch to it right now. [0] http://logs.openstack.org/45/358845/24/check/gate-neutron-dsvm-functional-ubuntu-xenial/b018ed7/testr_results.html.gz [1] https://github.com/openstack/neutron/blob/master/neutron/tests/functional/cmd/process_spawn.py#L107 [2] https://github.com/openstack/neutron/blob/master/neutron/tests/functional/cmd/test_netns_cleanup.py#L84 To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1652124/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
