Reviewed: https://review.openstack.org/350072 Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=7e150b2c0cb50f5fdd89644eb7334acca3c4ee92 Submitter: Jenkins Branch: master
commit 7e150b2c0cb50f5fdd89644eb7334acca3c4ee92 Author: liaozd <[email protected]> Date: Sun Dec 11 00:40:03 2016 +0800 Make the form _clean_rule_custom method full-fledged errors in the hidden fields will block form submit, drop all the other hidden fields. Not only the icmp_code and icmp_type, all the other fields not show in the custom rule should be excluded. Change-Id: Ibce7c00cb6ddb04d2d436dec79cb6b0b57bfc929 Closes-Bug: #1608977 ** Changed in: horizon Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1608977 Title: When add custom rule of the security group rules, hidden field errors block form submit Status in OpenStack Dashboard (Horizon): Fix Released Bug description: When create custom rule in the security group rules, if there are errors in the hidden fields: 'icmp_code', 'icmp_type', 'from_port', 'to_port', 'port', form submit will be blocked. Like: In the url: /project/access_and_security/ click the `Manage Rules` button in the `Actions` column. In "Add Rule" form for one "Security Group" Step-1: Make an invalid input in the form, only if the wrong input is not for the "Other Protocol" of "Rule" choice, like: When open up the "Add Rule" form, the "Custom TCP Rule" is the default startup option. Then you put a wrong number in the "Port" input field, like -1 (The valid number is 1-65535), then click "Add" button. The clean method will not pass and raise "The specified port is invalid." error for the form, and a "Not a valid port number" error for the "Port" input field. Step-2: Then you switch to choose the "Other Protocol" for "Rule" choice menu, input a valid number between 0-255, then click "Add" button. At this time, the form will not be submitted, it will come back without any notice. Because the error we created in Step-1 blocks it. You can switch back to the startup "Custom TCP Rule" choice menu, the error is still there. We need to pop every input field other than "IP Protocol". To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1608977/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
