Reviewed: https://review.openstack.org/419558 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=d33a2b1cbb0fb497b8612ee66822cd48fe4acfe6 Submitter: Jenkins Branch: master
commit d33a2b1cbb0fb497b8612ee66822cd48fe4acfe6 Author: Matt Riedemann <[email protected]> Date: Thu Jan 12 11:49:52 2017 -0500 Make unit tests work with os-vif 1.4.0 The expected VIFHostUser object in this test is setting the vif_name field on the object which didn't actually exist until version 1.1 of that object which is being released in os-vif 1.4.0. The test passes against os-vif 1.3.0 and VIFHostUser 1.0 today because the obj_to_primitive() routine will not include anything that's not a field on the object, which is vif_name in this case. But when moving to os-vif 1.4.0, we're hitting a failure because the expected object has vif_name set but the actual object doesn't because though the vif_name field is defined, it's not actually used yet in the code, so it's not set in the primitive and our object comparison fails. Change-Id: I1c27726d583a41ab69d9eab23e8484e7e047942d Closes-Bug: #1656025 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1656025 Title: os-vif 1.4.0 breaks nova unit tests Status in OpenStack Compute (nova): Fix Released Bug description: Seen here in the patch that bumps upper-constraints to use os-vif 1.4.0: http://logs.openstack.org/21/418421/4/check/gate-cross-nova-python27 -db-ubuntu-xenial/376a0f3/console.html#_2017-01-11_10_21_37_885392 'vif_name': u'nicdc065497-3c' is a new field in 1.4.0: https://review.openstack.org/#/c/390225/ The nova unit tests are using a strict expected representation of the vif object at version 1.0 so the new field breaks things. To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1656025/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
