Reviewed: https://review.openstack.org/419896 Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=e74b45d0eb923129902f1926aaddb51e6e2b8085 Submitter: Jenkins Branch: master
commit e74b45d0eb923129902f1926aaddb51e6e2b8085 Author: YAMAMOTO Takashi <yamam...@midokura.com> Date: Fri Jan 13 11:50:06 2017 +0000 Revert "Protect against non-determinstic sort" This reverts commit 175bfe048283ae930b60b1cea87874d1fa1d10d6. The change causes the following error if you're unlucky enough to have such a marker column. ArgumentError: Only '=', '!=', 'is_()', 'isnot()' operators can be used with None/True/False I saw test_floatingip_list_with_pagination failing, where fixed_port_id of the marker was None. Closes-Bug: #1656262 Change-Id: I6c32949d789f25d877d329ef0ae9d8650cb81acf ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1656262 Title: test_floatingip_list_with_pagination failure Status in networking-midonet: In Progress Status in neutron: Fix Released Bug description: midonet.neutron.tests.unit.test_midonet_plugin_ml2.TestMidonetL3NatExtraRoute.test_floatingip_list_with_pagination_reverse -------------------------------------------------------------------------------------------------------------------------- Captured traceback: ~~~~~~~~~~~~~~~~~~~ Traceback (most recent call last): File "/Users/yamamoto/git/networking-midonet/.tox/py27/src/neutron/neutron/tests/base.py", line 114, in func return f(self, *args, **kwargs) File "/Users/yamamoto/git/networking-midonet/.tox/py27/src/neutron/neutron/tests/base.py", line 114, in func return f(self, *args, **kwargs) File "/Users/yamamoto/git/networking-midonet/.tox/py27/src/neutron/neutron/tests/base.py", line 114, in func return f(self, *args, **kwargs) File "/Users/yamamoto/git/networking-midonet/.tox/py27/src/neutron/neutron/tests/unit/extensions/test_l3.py", line 2730, in test_floatingip_list_with_pagination_reverse ('floating_ip_address', 'asc'), 2, 2) File "/Users/yamamoto/git/networking-midonet/.tox/py27/src/neutron/neutron/tests/unit/db/test_db_base_plugin_v2.py", line 746, in _test_list_with_pagination_reverse self.assertThat(len(res[resources]), KeyError: 'floatingips' Captured pythonlogging: ~~~~~~~~~~~~~~~~~~~~~~~ WARNING [neutron.agent.securitygroups_rpc] Driver configuration doesn't match with enable_security_group WARNING [neutron.plugins.ml2.managers] Host filtering is disabled because at least one mechanism doesn't support it. WARNING [neutron.agent.securitygroups_rpc] Driver configuration doesn't match with enable_security_group WARNING [neutron.scheduler.dhcp_agent_scheduler] No more DHCP agents WARNING [neutron.api.rpc.agentnotifiers.dhcp_rpc_agent_api] Unable to schedule network 85a36d0b-3950-4c3b-aa00-8fbdab2b48a4: no agents available; will retry on subsequent port and subnet creation events. WARNING [neutron.scheduler.dhcp_agent_scheduler] No more DHCP agents WARNING [neutron.api.rpc.agentnotifiers.dhcp_rpc_agent_api] Unable to schedule network ce168e7d-70e7-412a-8333-711c3f13890b: no agents available; will retry on subsequent port and subnet creation events. WARNING [neutron.scheduler.dhcp_agent_scheduler] No more DHCP agents WARNING [neutron.api.rpc.agentnotifiers.dhcp_rpc_agent_api] Unable to schedule network c15a7692-272e-4140-bd9a-2faa8287deeb: no agents available; will retry on subsequent port and subnet creation events. WARNING [neutron.scheduler.dhcp_agent_scheduler] No more DHCP agents WARNING [neutron.api.rpc.agentnotifiers.dhcp_rpc_agent_api] Unable to schedule network 85a36d0b-3950-4c3b-aa00-8fbdab2b48a4: no agents available; will retry on subsequent port and subnet creation events. WARNING [neutron.scheduler.dhcp_agent_scheduler] No more DHCP agents WARNING [neutron.api.rpc.agentnotifiers.dhcp_rpc_agent_api] Unable to schedule network ce168e7d-70e7-412a-8333-711c3f13890b: no agents available; will retry on subsequent port and subnet creation events. WARNING [neutron.scheduler.dhcp_agent_scheduler] No more DHCP agents WARNING [neutron.api.rpc.agentnotifiers.dhcp_rpc_agent_api] Unable to schedule network c15a7692-272e-4140-bd9a-2faa8287deeb: no agents available; will retry on subsequent port and subnet creation events. ERROR [neutron.api.v2.resource] index failed: No details. Traceback (most recent call last): File "/Users/yamamoto/git/networking-midonet/.tox/py27/src/neutron/neutron/api/v2/resource.py", line 79, in resource result = method(request=request, **args) File "/Users/yamamoto/git/networking-midonet/.tox/py27/src/neutron/neutron/db/api.py", line 92, in wrapped setattr(e, '_RETRY_EXCEEDED', True) File "/Users/yamamoto/git/networking-midonet/.tox/py27/lib/python2.7/site-packages/oslo_utils/excutils.py", line 220, in __exit__ self.force_reraise() File "/Users/yamamoto/git/networking-midonet/.tox/py27/lib/python2.7/site-packages/oslo_utils/excutils.py", line 196, in force_reraise six.reraise(self.type_, self.value, self.tb) File "/Users/yamamoto/git/networking-midonet/.tox/py27/src/neutron/neutron/db/api.py", line 88, in wrapped return f(*args, **kwargs) File "/Users/yamamoto/git/networking-midonet/.tox/py27/lib/python2.7/site-packages/oslo_db/api.py", line 151, in wrapper ectxt.value = e.inner_exc File "/Users/yamamoto/git/networking-midonet/.tox/py27/lib/python2.7/site-packages/oslo_utils/excutils.py", line 220, in __exit__ self.force_reraise() File "/Users/yamamoto/git/networking-midonet/.tox/py27/lib/python2.7/site-packages/oslo_utils/excutils.py", line 196, in force_reraise six.reraise(self.type_, self.value, self.tb) File "/Users/yamamoto/git/networking-midonet/.tox/py27/lib/python2.7/site-packages/oslo_db/api.py", line 139, in wrapper return f(*args, **kwargs) File "/Users/yamamoto/git/networking-midonet/.tox/py27/src/neutron/neutron/db/api.py", line 128, in wrapped traceback.format_exc()) File "/Users/yamamoto/git/networking-midonet/.tox/py27/lib/python2.7/site-packages/oslo_utils/excutils.py", line 220, in __exit__ self.force_reraise() File "/Users/yamamoto/git/networking-midonet/.tox/py27/lib/python2.7/site-packages/oslo_utils/excutils.py", line 196, in force_reraise six.reraise(self.type_, self.value, self.tb) File "/Users/yamamoto/git/networking-midonet/.tox/py27/src/neutron/neutron/db/api.py", line 123, in wrapped return f(*dup_args, **dup_kwargs) File "/Users/yamamoto/git/networking-midonet/.tox/py27/src/neutron/neutron/api/v2/base.py", line 369, in index return self._items(request, True, parent_id) File "/Users/yamamoto/git/networking-midonet/.tox/py27/src/neutron/neutron/api/v2/base.py", line 308, in _items obj_list = obj_getter(request.context, **kwargs) File "/Users/yamamoto/git/networking-midonet/.tox/py27/src/neutron/neutron/db/api.py", line 163, in wrapped return method(*args, **kwargs) File "/Users/yamamoto/git/networking-midonet/.tox/py27/src/neutron/neutron/db/api.py", line 92, in wrapped setattr(e, '_RETRY_EXCEEDED', True) File "/Users/yamamoto/git/networking-midonet/.tox/py27/lib/python2.7/site-packages/oslo_utils/excutils.py", line 220, in __exit__ self.force_reraise() File "/Users/yamamoto/git/networking-midonet/.tox/py27/lib/python2.7/site-packages/oslo_utils/excutils.py", line 196, in force_reraise six.reraise(self.type_, self.value, self.tb) File "/Users/yamamoto/git/networking-midonet/.tox/py27/src/neutron/neutron/db/api.py", line 88, in wrapped return f(*args, **kwargs) File "/Users/yamamoto/git/networking-midonet/.tox/py27/lib/python2.7/site-packages/oslo_db/api.py", line 151, in wrapper ectxt.value = e.inner_exc File "/Users/yamamoto/git/networking-midonet/.tox/py27/lib/python2.7/site-packages/oslo_utils/excutils.py", line 220, in __exit__ self.force_reraise() File "/Users/yamamoto/git/networking-midonet/.tox/py27/lib/python2.7/site-packages/oslo_utils/excutils.py", line 196, in force_reraise six.reraise(self.type_, self.value, self.tb) File "/Users/yamamoto/git/networking-midonet/.tox/py27/lib/python2.7/site-packages/oslo_db/api.py", line 139, in wrapper return f(*args, **kwargs) File "/Users/yamamoto/git/networking-midonet/.tox/py27/src/neutron/neutron/db/api.py", line 128, in wrapped traceback.format_exc()) File "/Users/yamamoto/git/networking-midonet/.tox/py27/lib/python2.7/site-packages/oslo_utils/excutils.py", line 220, in __exit__ self.force_reraise() File "/Users/yamamoto/git/networking-midonet/.tox/py27/lib/python2.7/site-packages/oslo_utils/excutils.py", line 196, in force_reraise six.reraise(self.type_, self.value, self.tb) File "/Users/yamamoto/git/networking-midonet/.tox/py27/src/neutron/neutron/db/api.py", line 123, in wrapped return f(*dup_args, **dup_kwargs) File "/Users/yamamoto/git/networking-midonet/.tox/py27/src/neutron/neutron/db/l3_db.py", line 1413, in get_floatingips page_reverse=page_reverse) File "/Users/yamamoto/git/networking-midonet/.tox/py27/src/neutron/neutron/db/common_db_mixin.py", line 253, in _get_collection page_reverse=page_reverse) File "/Users/yamamoto/git/networking-midonet/.tox/py27/src/neutron/neutron/db/common_db_mixin.py", line 243, in _get_collection_query sort_dirs=sort_dirs) File "/Users/yamamoto/git/networking-midonet/.tox/py27/lib/python2.7/site-packages/oslo_db/sqlalchemy/utils.py", line 235, in paginate_query crit_attrs.append((model_attr > marker_values[i])) File "/Users/yamamoto/git/networking-midonet/.tox/py27/lib/python2.7/site-packages/sqlalchemy/sql/operators.py", line 318, in __gt__ return self.operate(gt, other) File "/Users/yamamoto/git/networking-midonet/.tox/py27/lib/python2.7/site-packages/sqlalchemy/orm/attributes.py", line 175, in operate return op(self.comparator, *other, **kwargs) File "/Users/yamamoto/git/networking-midonet/.tox/py27/lib/python2.7/site-packages/sqlalchemy/sql/operators.py", line 318, in __gt__ return self.operate(gt, other) File "/Users/yamamoto/git/networking-midonet/.tox/py27/lib/python2.7/site-packages/sqlalchemy/orm/properties.py", line 269, in operate return op(self.__clause_element__(), *other, **kwargs) File "/Users/yamamoto/git/networking-midonet/.tox/py27/lib/python2.7/site-packages/sqlalchemy/sql/operators.py", line 318, in __gt__ return self.operate(gt, other) File "/Users/yamamoto/git/networking-midonet/.tox/py27/lib/python2.7/site-packages/sqlalchemy/sql/elements.py", line 742, in operate return op(self.comparator, *other, **kwargs) File "/Users/yamamoto/git/networking-midonet/.tox/py27/lib/python2.7/site-packages/sqlalchemy/sql/operators.py", line 318, in __gt__ return self.operate(gt, other) File "<string>", line 1, in <lambda> File "/Users/yamamoto/git/networking-midonet/.tox/py27/lib/python2.7/site-packages/sqlalchemy/sql/type_api.py", line 60, in operate return o[0](self.expr, op, *(other + o[1:]), **kwargs) File "/Users/yamamoto/git/networking-midonet/.tox/py27/lib/python2.7/site-packages/sqlalchemy/sql/default_comparator.py", line 53, in _boolean_compare "Only '=', '!=', 'is_()', 'isnot()' operators can " ArgumentError: Only '=', '!=', 'is_()', 'isnot()' operators can be used with None/True/False Captured stderr: ~~~~~~~~~~~~~~~~ /Users/yamamoto/git/networking-midonet/.tox/py27/lib/python2.7/site-packages/oslo_db/sqlalchemy/enginefacade.py:259: OsloDBDeprecationWarning: EngineFacade is deprecated; please use oslo_db.sqlalchemy.enginefacade self._legacy_facade = LegacyEngineFacade(None, _factory=self) /Users/yamamoto/git/networking-midonet/.tox/py27/lib/python2.7/site-packages/paste/deploy/loadwsgi.py:22: DeprecationWarning: Parameters to load are deprecated. Call .resolve and .require separately. return pkg_resources.EntryPoint.parse("x=" + s).load(False) To manage notifications about this bug go to: https://bugs.launchpad.net/networking-midonet/+bug/1656262/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp