Reviewed: https://review.openstack.org/423499 Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=18acc704a1573346f751a2b8260720fd09e664cd Submitter: Jenkins Branch: master
commit 18acc704a1573346f751a2b8260720fd09e664cd Author: Ian Cordasco <[email protected]> Date: Fri Jan 20 19:21:52 2017 +0000 Fix regression introduced by Community Images Updating an image in v1 skipped the work to ensure that the image dictionary would be Image v2 compliant. It was hidden inside an else clause and was only run when there was no image id provided. This meant that only sometimes would is_public be appropriately converted to visibility. A functional test has been added to prevent regression and the code has been mildly altered to fix the issue. Closes-bug: #1658164 Change-Id: I996fbed2e31df8559c025cca31e5e12c4fb76548 ** Changed in: glance Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to Glance. https://bugs.launchpad.net/bugs/1658164 Title: community images breaks Images v1 API Status in Glance: Fix Released Bug description: The community images code has broken some v1 functionality. CI was reverted today by Change-Id: I03636966c6912af8fdc9fcfe49da3788e7316150 OSC reported failing functional tests. Test in question does an image-update in v1 to make an image public; test fails when the is_public value for the updated image is still false. An exception isn't raised in the test, so it's not a permissions problem. Looks like the call is accepted but the visibility value isn't changed properly. To manage notifications about this bug go to: https://bugs.launchpad.net/glance/+bug/1658164/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
