Reviewed: https://review.openstack.org/439766 Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=42631e311779b9a779ad8e7bd6654a58c6124fca Submitter: Jenkins Branch: master
commit 42631e311779b9a779ad8e7bd6654a58c6124fca Author: Kevin Benton <[email protected]> Date: Wed Mar 1 10:47:10 2017 -0800 Scan for mac through all devices The first device the agent happens to pick could be something without a mac address like a 6in6 interface. This was causing the agent to fail to start if it was unlucky enough to pick that address. This patch just adjusts the logic to keep iterating through the list until we find a mac. Closes-Bug: #1669087 Change-Id: I6e934a2dff8fd441e1c70c9a5857fd6150835e2a ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1669087 Title: linuxbridge-agent fails to start due to interface not having a mac address Status in neutron: Fix Released Bug description: Here's the traceback 2017-03-01 12:39:26.202 2412 ERROR oslo_service.service [req-91d75b8d-c462-41c2-bce5-a2f5dc8e6fa0 - - - - -] Error starting thread. 2017-03-01 12:39:26.202 2412 ERROR oslo_service.service Traceback (most recent call last): 2017-03-01 12:39:26.202 2412 ERROR oslo_service.service File "/usr/lib64/python2.7/site-packages/oslo_service/service.py", line 722, in run_service 2017-03-01 12:39:26.202 2412 ERROR oslo_service.service service.start() 2017-03-01 12:39:26.202 2412 ERROR oslo_service.service File "/usr/lib64/python2.7/site-packages/osprofiler/profiler.py", line 153, in wrapper 2017-03-01 12:39:26.202 2412 ERROR oslo_service.service return f(*args, **kwargs) 2017-03-01 12:39:26.202 2412 ERROR oslo_service.service File "/usr/lib64/python2.7/site-packages/neutron/plugins/ml2/drivers/agent/_common_agent.py", line 88, in start 2017-03-01 12:39:26.202 2412 ERROR oslo_service.service self.setup_rpc() 2017-03-01 12:39:26.202 2412 ERROR oslo_service.service File "/usr/lib64/python2.7/site-packages/osprofiler/profiler.py", line 153, in wrapper 2017-03-01 12:39:26.202 2412 ERROR oslo_service.service return f(*args, **kwargs) 2017-03-01 12:39:26.202 2412 ERROR oslo_service.service File "/usr/lib64/python2.7/site-packages/neutron/plugins/ml2/drivers/agent/_common_agent.py", line 157, in setup_rpc 2017-03-01 12:39:26.202 2412 ERROR oslo_service.service self.agent_id = self.mgr.get_agent_id() 2017-03-01 12:39:26.202 2412 ERROR oslo_service.service File "/usr/lib64/python2.7/site-packages/neutron/plugins/ml2/drivers/linuxbridge/agent/linuxbridge_neutron_agent.py", line 728, in get_agent_id 2017-03-01 12:39:26.202 2412 ERROR oslo_service.service return 'lb%s' % mac.replace(":", "") 2017-03-01 12:39:26.202 2412 ERROR oslo_service.service AttributeError: 'NoneType' object has no attribute 'replace' 2017-03-01 12:39:26.202 2412 ERROR oslo_service.service 2017-03-01 12:39:26.205 2412 INFO neutron.plugins.ml2.drivers.agent._common_agent [-] Stopping Linux bridge agent agent. 2017-03-01 12:39:26.206 2412 CRITICAL neutron [-] AttributeError: 'CommonAgentLoop' object has no attribute 'state_rpc' 2017-03-01 12:39:26.206 2412 ERROR neutron Traceback (most recent call last): 2017-03-01 12:39:26.206 2412 ERROR neutron File "/usr/lib/python-exec/python2.7/neutron-linuxbridge-agent", line 10, in <module> 2017-03-01 12:39:26.206 2412 ERROR neutron sys.exit(main()) 2017-03-01 12:39:26.206 2412 ERROR neutron File "/usr/lib64/python2.7/site-packages/neutron/cmd/eventlet/plugins/linuxbridge_neutron_agent.py", line 21, in main 2017-03-01 12:39:26.206 2412 ERROR neutron agent_main.main() 2017-03-01 12:39:26.206 2412 ERROR neutron File "/usr/lib64/python2.7/site-packages/neutron/plugins/ml2/drivers/linuxbridge/agent/linuxbridge_neutron_agent.py", line 936, in main 2017-03-01 12:39:26.206 2412 ERROR neutron launcher.wait() 2017-03-01 12:39:26.206 2412 ERROR neutron File "/usr/lib64/python2.7/site-packages/oslo_service/service.py", line 329, in wait 2017-03-01 12:39:26.206 2412 ERROR neutron status, signo = self._wait_for_exit_or_signal() 2017-03-01 12:39:26.206 2412 ERROR neutron File "/usr/lib64/python2.7/site-packages/oslo_service/service.py", line 314, in _wait_for_exit_or_signal 2017-03-01 12:39:26.206 2412 ERROR neutron self.stop() 2017-03-01 12:39:26.206 2412 ERROR neutron File "/usr/lib64/python2.7/site-packages/oslo_service/service.py", line 228, in stop 2017-03-01 12:39:26.206 2412 ERROR neutron self.services.stop() 2017-03-01 12:39:26.206 2412 ERROR neutron File "/usr/lib64/python2.7/site-packages/oslo_service/service.py", line 688, in stop 2017-03-01 12:39:26.206 2412 ERROR neutron service.stop() 2017-03-01 12:39:26.206 2412 ERROR neutron File "/usr/lib64/python2.7/site-packages/osprofiler/profiler.py", line 153, in wrapper 2017-03-01 12:39:26.206 2412 ERROR neutron return f(*args, **kwargs) 2017-03-01 12:39:26.206 2412 ERROR neutron File "/usr/lib64/python2.7/site-packages/neutron/plugins/ml2/drivers/agent/_common_agent.py", line 119, in stop 2017-03-01 12:39:26.206 2412 ERROR neutron self.set_rpc_timeout(self.quitting_rpc_timeout) 2017-03-01 12:39:26.206 2412 ERROR neutron File "/usr/lib64/python2.7/site-packages/osprofiler/profiler.py", line 153, in wrapper 2017-03-01 12:39:26.206 2412 ERROR neutron return f(*args, **kwargs) 2017-03-01 12:39:26.206 2412 ERROR neutron File "/usr/lib64/python2.7/site-packages/neutron/plugins/ml2/drivers/agent/_common_agent.py", line 471, in set_rpc_timeout 2017-03-01 12:39:26.206 2412 ERROR neutron self.state_rpc): 2017-03-01 12:39:26.206 2412 ERROR neutron AttributeError: 'CommonAgentLoop' object has no attribute 'state_rpc' 2017-03-01 12:39:26.206 2412 ERROR neutron fix was to just loop until we get an interface with a name (mac) To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1669087/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
