Public bug reported:
Note: this is exclusively from code inspection.
delete_instance_metadata and update_instance_metadata in ComputeManager
are both guarded by:
@check_instance_state(vm_state=[vm_states.ACTIVE, vm_states.PAUSED,
vm_states.SUSPENDED, vm_states.STOPPED],
task_state=None)
The problem is the task_state=None which, despite appearances, actually
explicitly disables the task_state check, i.e. it does not explicitly
check that task_state is None. This was introduced in change I70212879
and does not appear to have been deliberate.
** Affects: nova
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1669400
Title:
delete_instance_metadata and update_instance_metadata are permitted
during an ongoing task
Status in OpenStack Compute (nova):
New
Bug description:
Note: this is exclusively from code inspection.
delete_instance_metadata and update_instance_metadata in
ComputeManager are both guarded by:
@check_instance_state(vm_state=[vm_states.ACTIVE, vm_states.PAUSED,
vm_states.SUSPENDED, vm_states.STOPPED],
task_state=None)
The problem is the task_state=None which, despite appearances,
actually explicitly disables the task_state check, i.e. it does not
explicitly check that task_state is None. This was introduced in
change I70212879 and does not appear to have been deliberate.
To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1669400/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
