Reviewed: https://review.openstack.org/437222 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=f9ac9531fb3259fe83642dce92d0d1901d0f067e Submitter: Jenkins Branch: master
commit f9ac9531fb3259fe83642dce92d0d1901d0f067e Author: Balazs Gibizer <[email protected]> Date: Thu Mar 9 17:28:02 2017 +0100 Fix missing instance.delete notification The I8742071b55f018f864f5a382de20075a5b444a79 introduced cases when an instance object is destroyed without the instance.delete notification being emitted. This patch adds the necessary notification to restore legacy behaviour. Closes-Bug: #1665263 Change-Id: I55ce90ca34c927c5dcd340fa5bdb0607a4ad4971 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1665263 Title: instance.delete notification is missing for unscheduled instance Status in OpenStack Compute (nova): Fix Released Status in OpenStack Compute (nova) ocata series: In Progress Bug description: Description =========== It seems that the Move instance creation to conductor commit [1] changed when and how the instance.delete notification is emitted for an unscheduled instance. Unfortunately the legacy notification doesn't have test coverage and the versioned notification coverage are still on review [2] for this case. Before [1] the instance.delete for an unscheduled instance is emitted from here [3]. But after [1] the execution of the same delete operation goes to a new direction [4] and never reaches [3]. Before [1] the new test coverage in [2] was passing but now after [1] is merged the test_create_server_error fails as the instance.delete notification is not emitted. [1] https://review.openstack.org/#/c/319379 [2] https://review.openstack.org/#/c/410297 [3] https://review.openstack.org/#/c/410297/9/nova/compute/api.py@1860 [4] https://review.openstack.org/#/c/319379/84/nova/compute/api.py@1790 Steps to reproduce ================== Run the nova functional test in patch [2] before and after commit [1]. The test_create_server_error will pass before and fail after commit [1] due to missing instance.delete notification. Environment =========== Nova functional test env with based on commit f9d7b383a7cb12b6cd3e6117daf69b08620bf40f Logs & Configs ============== http://logs.openstack.org/97/410297/9/check/gate-nova-tox-functional- ubuntu-xenial/5875492/console.html#_2017-02-15_16_21_06_668774 To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1665263/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
