Reviewed: https://review.openstack.org/448799 Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=d04f164ab2d2472e181226201a68feaaf1454450 Submitter: Jenkins Branch: master
commit d04f164ab2d2472e181226201a68feaaf1454450 Author: Akihiro Motoki <[email protected]> Date: Wed Mar 22 21:41:50 2017 +0000 operation_log: Log mask_fields only when exists in request Previously mask_fields are always output even when they are not included in a user request. It is confusing. Change-Id: Ia207bfbc61246bc722a2ced544a8955f52025c0c Closes-Bug: #1675191 ** Changed in: horizon Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1675191 Title: operation_log: mask_fields are always recorded even if it is not contained in user parameters Status in OpenStack Dashboard (Horizon): Fix Released Bug description: operation_log middlware always output mask_fields even when they are not included in a user parameters. It is really confusing. horizon/middleware/operation_log.py for key in params.items(): # replace a value to a masked characters for key in self.mask_fields: <----- This should be 'if'..... params[key] = '*' * 8 To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1675191/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
